You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Qian Ye (JIRA)" <ji...@apache.org> on 2009/11/23 03:49:39 UTC

[jira] Created: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

When create a znode, a NULL ACL parameter cannot be accepted
------------------------------------------------------------

                 Key: ZOOKEEPER-589
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
             Project: Zookeeper
          Issue Type: Bug
          Components: c client
    Affects Versions: 3.2.1
         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux

            Reporter: Qian Ye


In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-589:
------------------------------------

    Attachment: ZOOKEEPER-524.patch

simple documentation patch. no tests needed.

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-524.patch
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831411#action_12831411 ] 

Hudson commented on ZOOKEEPER-589:
----------------------------------

Integrated in ZooKeeper-trunk #690 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/690/])
    . changed ZOOKEEPER-489 in changelog to .


> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-524.patch
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-589:
------------------------------------

    Status: Patch Available  (was: Open)

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-524.patch
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed reassigned ZOOKEEPER-589:
---------------------------------------

    Assignee: Benjamin Reed

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828239#action_12828239 ] 

Benjamin Reed commented on ZOOKEEPER-589:
-----------------------------------------

thanx for catching this eric!

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>             Fix For: 3.3.0
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829277#action_12829277 ] 

Hadoop QA commented on ZOOKEEPER-589:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12434699/ZOOKEEPER-524.patch
  against trunk revision 903483.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/console

This message is automatically generated.

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-524.patch
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831165#action_12831165 ] 

Mahadev konar commented on ZOOKEEPER-589:
-----------------------------------------

+1 for the patch.

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-524.patch
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-589:
------------------------------------

    Fix Version/s: 3.3.0

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>             Fix For: 3.3.0
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828238#action_12828238 ] 

Benjamin Reed commented on ZOOKEEPER-589:
-----------------------------------------

i think we should fix the client docs to reflect this behavior. "ACL of the parent" is a bit ambiguous if the parent's ACL changes after the create. it also will be problematic when we do federated ZooKeeper.

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>             Fix For: 3.3.0
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-589:
------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. thanks ben!

> When create a znode, a NULL ACL parameter cannot be accepted
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-589
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>         Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Qian Ye
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-524.patch
>
>
> In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.