[PR] Use airflow config in new UI [airflow]

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi opened a new pull request, #44252:
URL: https://github.com/apache/airflow/pull/44252

   Use the new public/config api endpoint to make sure the UI uses config values. The public endpoint can we switched off. So later on we should migrate this to a dedicated `ui/config` endpoint.
   
   Also, I didn't get around to `show_trigger_form_if_no_params` since we may also need API changes to make that work.
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use airflow config in new UI [airflow]

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on code in PR #44252:
URL: https://github.com/apache/airflow/pull/44252#discussion_r1852361061


##########
airflow/ui/src/queries/useConfig.tsx:
##########
@@ -0,0 +1,32 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { useConfigServiceGetConfig } from "openapi/queries";
+
+export const useConfig = (sectionName: string, configKey: string) => {
+  // TODO: replace with a ui/config endpoitn which will always return what the UI need to render

Review Comment:
   ```suggestion
     // TODO: replace with a ui/config endpoint which will always return what the UI need to render
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use airflow config in new UI [airflow]

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi merged PR #44252:
URL: https://github.com/apache/airflow/pull/44252


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org