[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #519: OAK-9722 Allow replacing default Azure SAS token generator

[GitBox <gi...@apache.org>]

mreutegg commented on code in PR #519:
URL: https://github.com/apache/jackrabbit-oak/pull/519#discussion_r842397950


##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureDataStore.java:
##########
@@ -41,17 +42,24 @@
 
     protected Properties properties;
 
+    private SasTokenGenerator sasTokenGenerator;
+
     private AzureBlobStoreBackend azureBlobStoreBackend;
 
     @Override
     protected AbstractSharedBackend createBackend() {
         azureBlobStoreBackend = new AzureBlobStoreBackend();
         if (null != properties) {
             azureBlobStoreBackend.setProperties(properties);
+            azureBlobStoreBackend.setSasTokenGenerator(sasTokenGenerator);

Review Comment:
   This doesn't look right to me. Why set the `sasTokenGenerator` only when there are `properties`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org