You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/08 14:04:45 UTC
[jira] [Commented] (CB-8615) (Windows) .winmd files with the same
names are not added properly when using framework tag with target attribute
[ https://issues.apache.org/jira/browse/CB-8615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734703#comment-14734703 ]
ASF GitHub Bot commented on CB-8615:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/301
CB-8615, CB-9588 Better Cordova plugin support for Windows 10 assemblies
* `target-dir` support for `<framework>` elements so that plugin devs can specify different subdirs for platform specific libs and avoid naming conflict(CB-8615)
* `<resource-file>` support(CB-9588)
* missing Windows10 project tests
* tests to cover CB-9588 and CB-8615
Some of unit tests might fail as we added tests for Windows10 project and there is the following fix which is required for correct semver work (CB-9601): https://github.com/apache/cordova-lib/pull/300
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8615
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #301
----
commit dbf054d7bec372de01f418590f3d51e652dc0c5e
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-09-03T16:19:28Z
CB-8615 (Windows) .winmd files with the same names are not added properly when using framework tag with target attribute
commit 06e7285b5941510a6073a0456189f092207ebc3e
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-09-04T18:12:43Z
CB-8615 Improves plugman tests for Windows
* Adds Windows10 project to tests
* Verifies <framework> copy dir
* Verifies <framework> reference string
* Adds tests for target-dir and versions attributes
commit a0546b747413674341084f09849adf85f043aff5
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-09-07T16:23:27Z
CB-9588 Plugman. Add support for <resource-file> on Windows
* Also includes corresponding unit tests
----
> (Windows) .winmd files with the same names are not added properly when using framework tag with target attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CB-8615
> URL: https://issues.apache.org/jira/browse/CB-8615
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Reporter: Alexander Sorokin
>
> When winmd files referenced by framework tag in plugin.xml have same names, only last one of them will be present in platform directory on plugin install.
> For example,
> {code:title=plugin.xml}
> <platform name="windows">
> ...
> <framework src="src/windows/lib/wpa/Microsoft.IdentityModel.Clients.ActiveDirectory.winmd" target="phone" custom="true"/>
> <framework src="src/windows/lib/netcore45/Microsoft.IdentityModel.Clients.ActiveDirectory.winmd" target="windows" custom="true"/>
> </platform>
> {code}
> When we install this plugin for windows platform, only the second winmd file is present in `platforms\windows\plugins\some.plugin.id` directory (apparently, the first lib is being replaced by the second one).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org