You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/16 21:23:25 UTC

[GitHub] [tvm] masahi opened a new pull request, #11330: [TIR] Simplify indices in layout transform

masahi opened a new pull request, #11330:
URL: https://github.com/apache/tvm/pull/11330

   Co-authored-by: Yuanjing Shi <yu...@octoml.ai>
   
   @vinx13 @shingjan 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 merged pull request #11330: [TIR] Simplify indices in layout transform

Posted by GitBox <gi...@apache.org>.

vinx13 merged PR #11330:
URL: https://github.com/apache/tvm/pull/11330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #11330: [TIR] Simplify indices in layout transform

Posted by GitBox <gi...@apache.org>.

Lunderberg commented on PR #11330:
URL: https://github.com/apache/tvm/pull/11330#issuecomment-1129000152

   Hmm, this is interesting.  The `IndexMapNode::MapIndices` function already includes a call to simplify, which I would have expected to handle this case.  For the test case, it looks like the first simplification didn't have the information that `0 <= vi < 16`, and so it couldn't simplify `floordiv(vi,16)` to `0`.
   
   Since we could have similar issues in other cases, I think we could generalize it by allowing `MapIndices` to take an optional `arith::Analyzer*` to be used in making the simplifications.  I'll see if that is a straightforward change to make.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org