[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #7029: Spark 3.3: Dataset writes for position deletes

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #7029:
URL: https://github.com/apache/iceberg/pull/7029#discussion_r1137736792


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -160,6 +177,10 @@ BatchWrite asRewrite(String fileSetID) {
     return new RewriteFiles(fileSetID);
   }
 
+  BatchWrite asPositionDeletesRewrite(String fileSetId) {

Review Comment:
   I don't think we share much of the logic in `SparkWriteBuilder` or in `SparkWrite`. What about creating separate hierarchy for that like we have for position deltas?
   
   ```
   SparkPositionDeletesRewriteBuilder implements WriteBuilder ...
   SparkPositionDeletesRewrite implements Write ...
   ```
   
   Otherwise, we complicate this class even more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org