You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/17 13:16:18 UTC
[GitHub] [tvm] MNGanesan opened a new pull request, #13798: Enhance the --help message of composite target's option description
MNGanesan opened a new pull request, #13798:
URL: https://github.com/apache/tvm/pull/13798
Presently --help for vitis displays the target and option string,
it has no description. Eg: target vitis-ai dpu<class 'str'>
This can be made more meaningful by fetching the description from the config node of the target. Eg: Vitis AI DPU identifier
Signed-off-by: MNGanesan <mn...@yahoo.co.uk>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by GitBox <gi...@apache.org>.
leandron commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1386739303
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by GitBox <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1386554388
Thanks @lhutton1 @Mousius , I'll working on the test and add it shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by "MNGanesan (via GitHub)" <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1403240240
Dropping this PR, moved by fix and test to new PR https://github.com/apache/tvm/pull/13842 under my branch enhance_help_msg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by "MNGanesan (via GitHub)" <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1402008753
Added the test via commit
commit f6bfd9ad4b055a0e2ddf627d153e67aa94ad8d30 (HEAD -> main, origin/main, origin/HEAD)
Author: MNGanesan <mn...@yahoo.co.uk>
Date: Tue Jan 24 13:58:00 2023 +0000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by "MNGanesan (via GitHub)" <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1403281073
Thanks @lHutton, I've moved the fix to new PR under a new branch Enhance the --help message of composite target by MNGanesan · Pull Request #13842 · apache/tvm
|
|
|
| | |
|
|
|
| |
Enhance the --help message of composite target by MNGanesan · Pull Reque...
Presently --help for vitis displays the target and option string, it has no description. Eg: target vitis-ai d...
|
|
|
Thanks,Ganesan
On Wednesday, 25 January 2023 at 00:25:23 GMT+5:30, Luke Hutton ***@***.***> wrote:
@lhutton1 commented on this pull request.
Thanks for adding the test @MNGanesan, it looks good to me :)
I took a quick look at the CI failures and they seem unrelated to your change. I wonder if your branch may need to be rebased onto the latest main?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: Enhance the --help message of composite target's option description
Posted by GitBox <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1385425749
Present --help string has no meaningful description, it simply prints the target, option name and python type
```
target vitis-ai:
--target-vitis-ai-dpu TARGET_VITIS_AI_DPU
**target vitis-ai dpu<class 'str'>**
--target-vitis-ai-build_dir TARGET_VITIS_AI_BUILD_DIR
**target vitis-ai build_dir<class 'str'>**
--target-vitis-ai-work_dir TARGET_VITIS_AI_WORK_DIR
**target vitis-ai work_dir<class 'str'>**
--target-vitis-ai-export_runtime_module TARGET_VITIS_AI_EXPORT_RUNTIME_MODULE
**target vitis-ai export_runtime_module<class 'str'>**
--target-vitis-ai-load_runtime_module TARGET_VITIS_AI_LOAD_RUNTIME_MODULE
**target vitis-ai load_runtime_module<class 'str'>**
```
This can be enhanced by accessing the config node of codegen target, which is retrieved in the front end
```
struct VitisAICompilerConfigNode : public tvm::AttrsNode<VitisAICompilerConfigNode> {
String dpu;
String build_dir;
String work_dir;
String export_runtime_module;
String load_runtime_module;
TVM_DECLARE_ATTRS(VitisAICompilerConfigNode, "ext.attrs.VitisAICompilerConfigNode") {
TVM_ATTR_FIELD(dpu).describe("Vitis AI DPU identifier").set_default("");
TVM_ATTR_FIELD(build_dir)
.describe("Build directory to be used (optional, debug)")
.set_default("");
TVM_ATTR_FIELD(work_dir)
.describe("Work directory to be used (optional, debug)")
.set_default("");
TVM_ATTR_FIELD(export_runtime_module)
.describe("Export the Vitis AI runtime module to this file")
.set_default("");
TVM_ATTR_FIELD(load_runtime_module)
```
Enhanced --help string after the fix
target vitis-ai:
```
--target-vitis-ai-dpu TARGET_VITIS_AI_DPU
**Vitis AI DPU identifier**
--target-vitis-ai-build_dir TARGET_VITIS_AI_BUILD_DIR
**Build directory to be used (optional, debug)**
--target-vitis-ai-work_dir TARGET_VITIS_AI_WORK_DIR
**Work directory to be used (optional, debug)**
--target-vitis-ai-export_runtime_module TARGET_VITIS_AI_EXPORT_RUNTIME_MODULE
**Export the Vitis AI runtime module to this file**
--target-vitis-ai-load_runtime_module TARGET_VITIS_AI_LOAD_RUNTIME_MODULE
**Load the Vitis AI runtime module to this file**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by "MNGanesan (via GitHub)" <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1403281885
Thanks,Ganesan
On Wednesday, 25 January 2023 at 14:27:25 GMT+5:30, M N Ganesan ***@***.***> wrote:
Thanks @lHutton, I've moved the fix to new PR under a new branch Enhance the --help message of composite target by MNGanesan · Pull Request #13842 · apache/tvm
|
|
|
| | |
|
|
|
| |
Enhance the --help message of composite target by MNGanesan · Pull Reque...
Presently --help for vitis displays the target and option string, it has no description. Eg: target vitis-ai d...
|
|
|
Thanks,Ganesan
On Wednesday, 25 January 2023 at 00:25:23 GMT+5:30, Luke Hutton ***@***.***> wrote:
@lhutton1 commented on this pull request.
Thanks for adding the test @MNGanesan, it looks good to me :)
I took a quick look at the CI failures and they seem unrelated to your change. I wonder if your branch may need to be rebased onto the latest main?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by "MNGanesan (via GitHub)" <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1402013058
Pushed the test via commit
commit f6bfd9ad4b055a0e2ddf627d153e67aa94ad8d30 (HEAD -> main, origin/main, origin/HEAD)Author: MNGanesan ***@***.***>Date: Tue Jan 24 13:58:00 2023 +0000
Thanks,Ganesan
On Tuesday, 17 January 2023 at 19:30:52 GMT+5:30, Luke Hutton ***@***.***> wrote:
@lhutton1 commented on this pull request.
Thanks @MNGanesan this looks like a sensible change to me. Would it be possible to add a test to check this case perhaps in tests/python/driver/tvmc/test_target_options.py?
Also cc @Mousius
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan commented on pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by "MNGanesan (via GitHub)" <gi...@apache.org>.
MNGanesan commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1402013672
Pushed the test via commit
commit f6bfd9ad4b055a0e2ddf627d153e67aa94ad8d30 (HEAD -> main, origin/main, origin/HEAD)Author: MNGanesan ***@***.***>Date: Tue Jan 24 13:58:00 2023 +0000
Thanks,Ganesan
On Wednesday, 18 January 2023 at 14:56:00 GMT+5:30, Leandro Nunes ***@***.***> wrote:
@tvm-bot rerun
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MNGanesan closed pull request #13798: [TVMC] Enhance the --help message of codegen target
Posted by "MNGanesan (via GitHub)" <gi...@apache.org>.
MNGanesan closed pull request #13798: [TVMC] Enhance the --help message of codegen target
URL: https://github.com/apache/tvm/pull/13798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13798: Enhance the --help message of composite target's option description
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13798:
URL: https://github.com/apache/tvm/pull/13798#issuecomment-1385409394
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org