You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/20 13:28:42 UTC

[GitHub] [incubator-nuttx] igrr commented on a change in pull request #4187: Fix xtensa_btdump() to look at the exception frame

igrr commented on a change in pull request #4187:
URL: https://github.com/apache/incubator-nuttx/pull/4187#discussion_r673122218



##########
File path: arch/xtensa/src/common/xtensa_dumpstate.c
##########
@@ -232,7 +232,11 @@ static inline void xtensa_btdump(void)
   int i;
   bool corrupted = false;
 
-  xtensa_backtrace_start(&pc, &sp, &npc);

Review comment:
       is xtensa_backtrace_start still used anywhere? if not, maybe arch/xtensa/src/common/xtensa_dumpstate.c can be removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org