You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/20 14:46:34 UTC
[GitHub] [dubbo-go] zouyx opened a new pull request #946: Ready for release 1.5.5
zouyx opened a new pull request #946:
URL: https://github.com/apache/dubbo-go/pull/946
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
* Add two PR for bug fix.
* `1.5` has included #945 , so not in this PR.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #946: Ready for release 1.5.5
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #946:
URL: https://github.com/apache/dubbo-go/pull/946#issuecomment-748617647
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=h1) Report
> Merging [#946](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=desc) (daede0f) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/9be9fef58157c87e8804c68a95b77344b4d1137f?el=desc) (9be9fef) will **increase** coverage by `0.07%`.
> The diff coverage is `87.09%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #946 +/- ##
==========================================
+ Coverage 59.85% 59.93% +0.07%
==========================================
Files 260 260
Lines 12855 12858 +3
==========================================
+ Hits 7695 7707 +12
+ Misses 4199 4187 -12
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `61.90% <60.00%> (+1.12%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <100.00%> (+0.16%)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.78% <100.00%> (+2.19%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <100.00%> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.67% <100.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <100.00%> (ø)` | |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <100.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <100.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=footer). Last update [9be9fef...daede0f](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #946: Ready for release 1.5.5
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #946:
URL: https://github.com/apache/dubbo-go/pull/946
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #946: Ready for release 1.5.5
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #946:
URL: https://github.com/apache/dubbo-go/pull/946#issuecomment-748617647
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=h1) Report
> Merging [#946](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=desc) (daede0f) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/9be9fef58157c87e8804c68a95b77344b4d1137f?el=desc) (9be9fef) will **increase** coverage by `0.09%`.
> The diff coverage is `87.09%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #946 +/- ##
==========================================
+ Coverage 59.85% 59.95% +0.09%
==========================================
Files 260 260
Lines 12855 12858 +3
==========================================
+ Hits 7695 7709 +14
+ Misses 4199 4185 -14
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `61.90% <60.00%> (+1.12%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <100.00%> (+0.16%)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.78% <100.00%> (+2.19%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <100.00%> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.67% <100.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <100.00%> (ø)` | |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <100.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=footer). Last update [9be9fef...daede0f](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #946: Ready for release 1.5.5
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #946:
URL: https://github.com/apache/dubbo-go/pull/946#issuecomment-748617647
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=h1) Report
> Merging [#946](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=desc) (8031b43) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/9be9fef58157c87e8804c68a95b77344b4d1137f?el=desc) (9be9fef) will **increase** coverage by `0.07%`.
> The diff coverage is `86.20%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #946 +/- ##
==========================================
+ Coverage 59.85% 59.93% +0.07%
==========================================
Files 260 260
Lines 12855 12856 +1
==========================================
+ Hits 7695 7705 +10
+ Misses 4199 4187 -12
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (ø)` | |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.52% <ø> (+1.92%)` | :arrow_up: |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `61.90% <60.00%> (+1.12%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <100.00%> (+0.16%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <100.00%> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.67% <100.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <100.00%> (ø)` | |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <100.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <100.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/dubbo-go/pull/946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=footer). Last update [9be9fef...daede0f](https://codecov.io/gh/apache/dubbo-go/pull/946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org