You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by dskarbek <gi...@git.apache.org> on 2016/12/14 18:38:58 UTC
[GitHub] qpid-dispatch pull request #:
Github user dskarbek commented on the pull request:
https://github.com/apache/qpid-dispatch/commit/611e7d6d078d1078d8e53b711285539506e536ea#commitcomment-20189814
In src/router_core/connections.c:
In src/router_core/connections.c on line 497:
why can't proton do the decref? Would be much better to have them be parallel. If there's a good reason that Proton can't take care of this, then that should be stated here as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [GitHub] qpid-dispatch pull request #:
Posted by Ted Ross <tr...@redhat.com>.
The issue here is that the link has been closed with pending/unsettled
deliveries on it. Proton's delivery records (pn_delivery_t) are
silently freed by Proton so we don't get the opportunity to cleanly
remove the references.
On 12/14/2016 01:38 PM, dskarbek wrote:
> Github user dskarbek commented on the pull request:
>
> https://github.com/apache/qpid-dispatch/commit/611e7d6d078d1078d8e53b711285539506e536ea#commitcomment-20189814
>
> In src/router_core/connections.c:
> In src/router_core/connections.c on line 497:
> why can't proton do the decref? Would be much better to have them be parallel. If there's a good reason that Proton can't take care of this, then that should be stated here as well.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org