[GitHub] [samza] prateekm commented on a change in pull request #1209: SAMZA-2324: Adding KV store metrics for rocksdb

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1209: SAMZA-2324: Adding KV store metrics for rocksdb
URL: https://github.com/apache/samza/pull/1209#discussion_r342867181
 
 

 ##########
 File path: samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
 ##########
 @@ -101,6 +102,8 @@ object RocksDbKeyValueStore extends Logging {
           }
         ))
 
+      metrics.newGauge("rocksdb.size-on-disk", () => FileUtils.sizeOfDirectory(new File(dir.getAbsolutePath)))
 
 Review comment:
   1. Why not use RocksDB internal metric?
   2. Regardless of 1, should not re-use the rocksdb internal metrics naming convention to report custom metrics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services