You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 21:40:15 UTC

[GitHub] [incubator-superset] ktmud commented on a change in pull request #11006: build: enable react-hooks linting

ktmud commented on a change in pull request #11006:
URL: https://github.com/apache/incubator-superset/pull/11006#discussion_r493049385



##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
  * under the License.
  */
 module.exports = {
-  extends: ['airbnb', 'prettier', 'prettier/react'],
+  extends: [
+    'airbnb',
+    'prettier',
+    'prettier/react',
+    'plugin:react-hooks/recommended',

Review comment:
       `eslint-airbnb` has also `airbnb/hooks` to extend from, but it throws errors for inexhaustive deps.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org