You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/13 05:27:50 UTC

[GitHub] [hive] rbalamohan commented on a diff in pull request #3204: HIVE-26136: Implement UPDATE statements for Iceberg tables

rbalamohan commented on code in PR #3204:
URL: https://github.com/apache/hive/pull/3204#discussion_r849088082


##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergV2.java:
##########
@@ -310,6 +310,39 @@ public void testDeleteStatementWithOtherTable() {
         HiveIcebergTestUtils.valueForRow(HiveIcebergStorageHandlerTestUtils.CUSTOMER_SCHEMA, objects), 0);
   }
 
+  @Test
+  public void testUpdateStatementUnpartitioned() {
+    Assume.assumeFalse("Iceberg UPDATEs are only implemented for non-vectorized mode for now", isVectorized);

Review Comment:
   Will reader go via non-vect* path when reading from an updated table?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org