You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2021/10/02 12:57:29 UTC
[maven-release] 01/01: [MRELEASE-1066] Use try-with-resources
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch MRELEASE-1066v2
in repository https://gitbox.apache.org/repos/asf/maven-release.git
commit b8f0d058d04e5d3183cf31abe81749e7247f820a
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Sat Oct 2 12:10:00 2021 +0200
[MRELEASE-1066] Use try-with-resources
---
.../release/phase/AbstractBackupPomsPhaseTest.java | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java
index ce8e00e..22c1a01 100644
--- a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java
+++ b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java
@@ -24,8 +24,11 @@ import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
import org.apache.maven.project.MavenProject;
import org.apache.maven.shared.release.PlexusJUnit4TestCase;
import org.codehaus.plexus.util.ReaderFactory;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
import java.io.File;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
@@ -76,17 +79,16 @@ public abstract class AbstractBackupPomsPhaseTest
return reactorProjects;
}
- private MavenProject createMavenProject( File pomFile )
- throws Exception
+ private MavenProject createMavenProject( File pomFile ) throws IOException, XmlPullParserException
{
MavenXpp3Reader reader = new MavenXpp3Reader();
-
- Model model = reader.read( ReaderFactory.newXmlReader( pomFile ) );
-
+ Model model;
+ try ( XmlStreamReader xmlStreamReader = ReaderFactory.newXmlReader( pomFile ))
+ {
+ model = reader.read( xmlStreamReader );
+ }
MavenProject project = new MavenProject( model );
-
project.setFile( pomFile );
-
return project;
}