You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/30 05:07:33 UTC
[GitHub] [hadoop-ozone] flirmnave commented on a change in pull request #884: HDDS-2406. Ozone shell key get throws IllegalArgumentException if pipeline is empty.
flirmnave commented on a change in pull request #884:
URL: https://github.com/apache/hadoop-ozone/pull/884#discussion_r417755897
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientManager.java
##########
@@ -168,7 +169,8 @@ private XceiverClientSpi acquireClient(Pipeline pipeline, boolean read)
throws IOException {
Preconditions.checkNotNull(pipeline);
Preconditions.checkArgument(pipeline.getNodes() != null);
- Preconditions.checkArgument(!pipeline.getNodes().isEmpty());
+ Preconditions.checkArgument(!pipeline.getNodes().isEmpty(),
+ FAILED_TO_FIND_HEALTHY_NODES);
Review comment:
Thanks @adoroszlai for review, I change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org