You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Jens Kapitza (JIRA)" <ji...@apache.org> on 2012/06/05 13:55:22 UTC

[jira] [Created] (PDFBOX-1329) Update PDPage to enum

Jens Kapitza created PDFBOX-1329:
------------------------------------

             Summary: Update PDPage to enum
                 Key: PDFBOX-1329
                 URL: https://issues.apache.org/jira/browse/PDFBOX-1329
             Project: PDFBox
          Issue Type: Improvement
          Components: PDModel
    Affects Versions: 1.8.0
         Environment: Linux, UBUNTU 12.04, openjdk-7
            Reporter: Jens Kapitza
            Priority: Minor
         Attachments: change_pdpage.diff



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PDFBOX-1329) Update PDPage to enum

Posted by "Jens Kapitza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Kapitza updated PDFBOX-1329:
---------------------------------

    Attachment: change_pdpage.diff

the changes for the example and the two files
                
> Update PDPage to enum
> ---------------------
>
>                 Key: PDFBOX-1329
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1329
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 1.8.0
>         Environment: Linux, UBUNTU 12.04, openjdk-7
>            Reporter: Jens Kapitza
>            Priority: Minor
>         Attachments: change_pdpage.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PDFBOX-1329) Update PDPage to enum

Posted by "Timo Boehme (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289363#comment-13289363 ] 

Timo Boehme commented on PDFBOX-1329:
-------------------------------------

Thanks for the contribution but mind the following points:
- as I already wrote in my email to dev@pdfbox.apache.org enum changes like this break compatibility (e.g. you deleted
  public constants), thus this won't be applied as long as there is no major release
- please insert only relevant files in patches (leave out e.g. app/pom.xml; classes with only reordered import declarations or
  only removed empty lines)
- please don't use wildcard (*) in import

For the time being I would propose contributing by adding Generics where this does not break compatibility.
                
> Update PDPage to enum
> ---------------------
>
>                 Key: PDFBOX-1329
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1329
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 1.8.0
>         Environment: Linux, UBUNTU 12.04, openjdk-7
>            Reporter: Jens Kapitza
>            Priority: Minor
>         Attachments: change_pdpage.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira