svn commit: r1135229 - in /commons/proper/pool/trunk/src/test/org/apache/commons/pool2: PrivateException.java TestBaseKeyedObjectPool.java TestBaseObjectPool.java

[ma...@apache.org]

Author: markt
Date: Mon Jun 13 19:13:18 2011
New Revision: 1135229

URL: http://svn.apache.org/viewvc?rev=1135229&view=rev
Log:
Fix some Eclipse warnings

Modified:
    commons/proper/pool/trunk/src/test/org/apache/commons/pool2/PrivateException.java
    commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseKeyedObjectPool.java
    commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseObjectPool.java

Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool2/PrivateException.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool2/PrivateException.java?rev=1135229&r1=1135228&r2=1135229&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool2/PrivateException.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool2/PrivateException.java Mon Jun 13 19:13:18 2011
@@ -21,6 +21,8 @@ package org.apache.commons.pool2;
  * An exception that only is thrown by these tests.
  */
 public class PrivateException extends RuntimeException {
+    private static final long serialVersionUID = 1L;
+
     public PrivateException(final String message) {
         super(message);
     }

Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseKeyedObjectPool.java?rev=1135229&r1=1135228&r2=1135229&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseKeyedObjectPool.java Mon Jun 13 19:13:18 2011
@@ -46,6 +46,7 @@ public class TestBaseKeyedObjectPool ext
      * idle and active objects, or
      * throw {@link IllegalArgumentException}
      * if such a pool cannot be created.
+     * @param mincapacity 
      */
     protected KeyedObjectPool<Object,Object> makeEmptyPool(int mincapacity) {
         if (this.getClass() != TestBaseKeyedObjectPool.class) {
@@ -58,6 +59,8 @@ public class TestBaseKeyedObjectPool ext
      * Return what we expect to be the n<sup>th</sup>
      * object (zero indexed) created by the pool
      * for the given key.
+     * @param key 
+     * @param n 
      */
     protected Object getNthObject(Object key, int n) {
         if (this.getClass() != TestBaseKeyedObjectPool.class) {
@@ -66,6 +69,9 @@ public class TestBaseKeyedObjectPool ext
         throw new UnsupportedOperationException("BaseKeyedObjectPool isn't a complete implementation.");
     }
 
+    /**
+     * @param n  
+     */
     protected Object makeKey(int n) {
         if (this.getClass() != TestBaseKeyedObjectPool.class) {
             fail("Subclasses of TestBaseKeyedObjectPool must reimplement this method.");

Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseObjectPool.java?rev=1135229&r1=1135228&r2=1135229&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool2/TestBaseObjectPool.java Mon Jun 13 19:13:18 2011
@@ -31,6 +31,9 @@ import org.junit.Test;
 public class TestBaseObjectPool extends TestObjectPool {
     private ObjectPool<Object> _pool = null;
 
+    /**
+     * @param mincapacity  
+     */
     protected ObjectPool<Object> makeEmptyPool(int mincapacity) {
         if (this.getClass() != TestBaseObjectPool.class) {
             fail("Subclasses of TestBaseObjectPool must reimplement this method.");
@@ -46,6 +49,9 @@ public class TestBaseObjectPool extends 
         throw new UnsupportedOperationException("BaseObjectPool isn't a complete implementation.");
     }
 
+    /**
+     * @param n  
+     */
     protected Object getNthObject(final int n) {
         if (this.getClass() != TestBaseObjectPool.class) {
             fail("Subclasses of TestBaseObjectPool must reimplement this method.");