You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/17 14:50:24 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #24528: Do not calculate grid root instances
bbovenzi opened a new pull request, #24528:
URL: https://github.com/apache/airflow/pull/24528
We were calculating `instances` for the root of `grid_data` but we didn't use that information for anything. Instead we should detect when it is the root node and only return what is necessary
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #24528: Do not calculate grid root instances
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #24528:
URL: https://github.com/apache/airflow/pull/24528#discussion_r900209358
##########
airflow/www/views.py:
##########
@@ -387,6 +387,14 @@ def get_summary(dag_run, children):
'end_date': group_end_date,
}
+ # We don't need to calculate summaries for the root
+ if task_group.group_id is None:
+ return {
+ 'id': task_group.group_id,
+ 'children': children,
+ 'instances': [],
Review Comment:
Will not having `label` here confuse your Typescript changes in the UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24528: Do not calculate grid root instances
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24528:
URL: https://github.com/apache/airflow/pull/24528#issuecomment-1158963029
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #24528: Do not calculate grid root instances
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #24528:
URL: https://github.com/apache/airflow/pull/24528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org