You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/07 15:29:49 UTC

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4204: #4182, ignore showLike context in show columns

terrymanu commented on a change in pull request #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204#discussion_r376452105
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
 ##########
 @@ -40,7 +40,7 @@ showTableStatus
     ;
 
 showColumns
-    : SHOW EXTENDED? FULL? (COLUMNS | FIELDS) fromTable fromSchema? (showLike | showWhereClause_)?
+    : SHOW EXTENDED? FULL? (COLUMNS | FIELDS) fromTable fromSchema?  (showLike_ | showWhereClause_)?
 
 Review comment:
   `showLike_` and `showLike` can make developer confuse.
   It is better to rename `showLike_` to `showColumnLike_`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services