You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/02 21:08:19 UTC
[GitHub] [iceberg] aokolnychyi opened a new issue #1548: Consider adding extra validation for metrics config when creating a table
aokolnychyi opened a new issue #1548:
URL: https://github.com/apache/iceberg/issues/1548
What I see frequently is that people clone some examples but miss to update the metrics config. As a result, it points to fields that don't exist. I think we should consider doing some checks while creating a table to ensure metrics config references columns in our schema. It is important to get the metrics config right while creating a table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] holdenk commented on issue #1548: Consider adding extra validation for metrics config when creating a table
Posted by GitBox <gi...@apache.org>.
holdenk commented on issue #1548:
URL: https://github.com/apache/iceberg/issues/1548#issuecomment-746730051
Rocking, I've finally got a bit of time for next week, I'll pick this up :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] SteNicholas commented on issue #1548: Consider adding extra validation for metrics config when creating a table
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1548:
URL: https://github.com/apache/iceberg/issues/1548#issuecomment-708938985
@aokolnychyi IMO, `MetricsConfig` could add `validateProperties` method to check metrics config references columns in schema, and the method should be called in `createTable()`. Is this similar with your point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on issue #1548: Consider adding extra validation for metrics config when creating a table
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on issue #1548:
URL: https://github.com/apache/iceberg/issues/1548#issuecomment-718089040
@SteNicholas, yeah, that's something I had in mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on issue #1548: Consider adding extra validation for metrics config when creating a table
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on issue #1548:
URL: https://github.com/apache/iceberg/issues/1548#issuecomment-707913044
@holdenk, would you have time to look into this? Not urgent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org