You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajkoti (via GitHub)" <gi...@apache.org> on 2023/06/11 19:50:55 UTC

[GitHub] [airflow] pankajkoti opened a new pull request, #31849: Restrict direct usage of driver params via extras for JDBC connection

pankajkoti opened a new pull request, #31849:
URL: https://github.com/apache/airflow/pull/31849

   Restrict direct usage of driver params via extras and add 
   configuration requirements to allow it. Additionally,
   several other ways have been added to achieve setting
   the driver parameters.
   
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #31849: Restrict direct usage of driver params via extras for JDBC connection

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31849:
URL: https://github.com/apache/airflow/pull/31849#issuecomment-1586323231

   som docs problem :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] eladkal commented on a diff in pull request #31849: Restrict direct usage of driver params via extras for JDBC connection

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #31849:
URL: https://github.com/apache/airflow/pull/31849#discussion_r1226083044


##########
airflow/providers/jdbc/CHANGELOG.rst:
##########
@@ -24,6 +24,20 @@
 Changelog
 ---------
 
+4.0.0

Review Comment:
   Please also add 4.0.0 to provider yaml



##########
docs/spelling_wordlist.txt:
##########
@@ -788,6 +788,7 @@ javascript
 jaydebeapi
 Jdbc
 jdbc
+JdbcHook

Review Comment:
   This seems redundant.
   Use the ` char when you specify JdbcHook then the spelling check will treat it as code and wont raise issues



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #31849: Restrict direct usage of driver params via extras for JDBC connection

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31849:
URL: https://github.com/apache/airflow/pull/31849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org