[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2225: CASSANDRA-18124 Make keystore_password nullable

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on code in PR #2225:
URL: https://github.com/apache/cassandra/pull/2225#discussion_r1146947937


##########
examples/ssl-factory/src/org/apache/cassandra/security/KubernetesSecretsPEMSslContextFactory.java:
##########
@@ -135,12 +137,12 @@ public KubernetesSecretsPEMSslContextFactory(Map<String, Object> parameters)
         super(parameters);
 
         pemEncodedKey = getValueFromEnv(getString(PEMConfigKey.PRIVATE_KEY_ENV_VAR, DEFAULT_PRIVATE_KEY_ENV_VAR_NAME),
-                                        DEFAULT_PRIVATE_KEY);

Review Comment:
   there are all these instances of changed formatting, can we return it back as it was? it happens in the below class too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org