You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jo...@apache.org on 2016/10/10 18:23:22 UTC

[5/6] mesos git commit: Added TODO describing a common gotcha.

Added TODO describing a common gotcha.

Review: https://reviews.apache.org/r/52618/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/823b2dfe
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/823b2dfe
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/823b2dfe

Branch: refs/heads/master
Commit: 823b2dfe3a2c262c4811092ab6aeca02823dda5a
Parents: c60a82b
Author: Neil Conway <ne...@gmail.com>
Authored: Mon Oct 10 10:39:33 2016 -0700
Committer: Joseph Wu <jo...@apache.org>
Committed: Mon Oct 10 11:19:15 2016 -0700

----------------------------------------------------------------------
 src/tests/utils.cpp | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/823b2dfe/src/tests/utils.cpp
----------------------------------------------------------------------
diff --git a/src/tests/utils.cpp b/src/tests/utils.cpp
index 218facb..fc004a9 100644
--- a/src/tests/utils.cpp
+++ b/src/tests/utils.cpp
@@ -45,6 +45,9 @@ JSON::Object Metrics()
 {
   process::UPID upid("metrics", process::address());
 
+  // TODO(neilc): This request might timeout if the current value of a
+  // metric cannot be determined. In tests, a common cause for this is
+  // MESOS-6231 when multiple scheduler drivers are in use.
   process::Future<process::http::Response> response =
     process::http::get(upid, "snapshot");