You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/07/03 11:39:49 UTC
[PR] refactor(client): use SLF4J parameterized logging instead of string c⦠[hudi]
voonhous opened a new pull request, #19155:
URL: https://github.com/apache/hudi/pull/19155
β¦oncatenation
Convert `+`-concatenated log messages to SLF4J `{}` placeholders across hudi-client (client-common, java-client, spark-client, flink-client).
The rewrite is behaviour-preserving: each concatenated expression becomes a placeholder argument in order, and a trailing throwable is kept as the last argument so its stack trace is still recorded. This also avoids building the message string eagerly when the log level is disabled.
Claude-Session: https://claude.ai/code/session_01FpDcDnw5gVVKBfPeEqJ3Fk
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the changes
(or) link to an issue by including `Closes #<issue-number>` for context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in behavior.
Followed by a detailed log of all the changes. Highlight if any code was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
If medium or high, explain what verification was done to mitigate the risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4879796672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
}, {
"hash" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165",
"triggerID" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* 38ebb72dedc8d0c11abdf4bcb24e296efef923c3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #19155:
URL: https://github.com/apache/hudi/pull/19155#discussion_r3522931383
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -109,8 +109,7 @@ public HoodieBinaryCopyHandle(
}
public void write() {
- log.info("Start to merge source files " + this.inputFiles + " into target file: " + this.path
- + ". Please pay attention that we will not rolling files based on max-file-size config during binary copy.");
+ log.info("Start to merge source files {} into target file: {}. Please pay attention that we will not rolling files based on max-file-size config during binary copy.", this.inputFiles, this.path);
Review Comment:
Done - kept the format string on one line and moved `this.inputFiles, this.path` to the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #19155:
URL: https://github.com/apache/hudi/pull/19155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4878828074
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
}, {
"hash" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165",
"triggerID" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* c8a01457dc13d38a8e71582da61d8344c02ec481 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153)
* 38ebb72dedc8d0c11abdf4bcb24e296efef923c3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4883016335
@wombatu-kun Can i get a re-review on this mechanical PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4878703465
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
}, {
"hash" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* c8a01457dc13d38a8e71582da61d8344c02ec481 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153)
* 38ebb72dedc8d0c11abdf4bcb24e296efef923c3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4876196845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93db83836a12a39256b69b426984e3cab1a2bf72 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149)
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* c8a01457dc13d38a8e71582da61d8344c02ec481 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #19155:
URL: https://github.com/apache/hudi/pull/19155#discussion_r3519786894
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -463,7 +463,7 @@ private boolean deleteArchivedInstants(List<HoodieInstant> archivedInstants, Hoo
public void archive(HoodieEngineContext context, List<HoodieInstant> instants) throws HoodieCommitException {
try {
Schema wrapperSchema = HoodieArchivedMetaEntry.getClassSchema();
- log.info("Wrapper schema " + wrapperSchema.toString());
+ log.info("Wrapper schema {}", wrapperSchema.toString());
Review Comment:
Done. Dropped `.toString()` in `TimelineArchiverV1` and `HoodieCompactionPlanGenerator` (plus the matching test in `TestLegacyArchivedMetaEntryReader`). `LSMTimelineWriter` already passes the schema object straight through after the rebase, so nothing needed there.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/plan/generators/HoodieCompactionPlanGenerator.java:
##########
@@ -47,7 +47,7 @@ public HoodieCompactionPlanGenerator(HoodieTable table, HoodieEngineContext engi
BaseTableServicePlanActionExecutor executor) {
super(table, engineContext, writeConfig, executor);
this.compactionStrategy = writeConfig.getCompactionStrategy();
- log.info("Compaction Strategy used is: " + compactionStrategy.toString());
+ log.info("Compaction Strategy used is: {}", compactionStrategy.toString());
Review Comment:
Done here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4881495703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
}, {
"hash" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165",
"triggerID" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"triggerType" : "PUSH"
}, {
"hash" : "55b4be9efe3e88dbcba41f3ae2210dec6b17ac66",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55b4be9efe3e88dbcba41f3ae2210dec6b17ac66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* 38ebb72dedc8d0c11abdf4bcb24e296efef923c3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165)
* 55b4be9efe3e88dbcba41f3ae2210dec6b17ac66 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4877178705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* c8a01457dc13d38a8e71582da61d8344c02ec481 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4875788787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93db83836a12a39256b69b426984e3cab1a2bf72 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4876744378
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93db83836a12a39256b69b426984e3cab1a2bf72 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149)
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* c8a01457dc13d38a8e71582da61d8344c02ec481 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #19155:
URL: https://github.com/apache/hudi/pull/19155#discussion_r3521728141
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -109,8 +109,7 @@ public HoodieBinaryCopyHandle(
}
public void write() {
- log.info("Start to merge source files " + this.inputFiles + " into target file: " + this.path
- + ". Please pay attention that we will not rolling files based on max-file-size config during binary copy.");
+ log.info("Start to merge source files {} into target file: {}. Please pay attention that we will not rolling files based on max-file-size config during binary copy.", this.inputFiles, this.path);
Review Comment:
π€ nit: the original was split across two lines for readability; collapsing it into a single ~200-char line makes it harder to scan. Could you keep the format string and arguments on separate lines, e.g. `log.info("Start to merge source files {} into target file: {}. ...",\n this.inputFiles, this.path)`?
<sub><i>β οΈ AI-generated; verify before applying. React π/π to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #19155:
URL: https://github.com/apache/hudi/pull/19155#discussion_r3519664769
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -463,7 +463,7 @@ private boolean deleteArchivedInstants(List<HoodieInstant> archivedInstants, Hoo
public void archive(HoodieEngineContext context, List<HoodieInstant> instants) throws HoodieCommitException {
try {
Schema wrapperSchema = HoodieArchivedMetaEntry.getClassSchema();
- log.info("Wrapper schema " + wrapperSchema.toString());
+ log.info("Wrapper schema {}", wrapperSchema.toString());
Review Comment:
π€ nit: now that you're using parameterized logging, the explicit `.toString()` call is redundant β SLF4J will call it lazily only if the log level is enabled. Could you drop it here (and the same pattern in `LSMTimelineWriter.java` and `HoodieCompactionPlanGenerator.java`)? `log.info("Wrapper schema {}", wrapperSchema)` is enough.
<sub><i>β οΈ AI-generated; verify before applying. React π/π to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/plan/generators/HoodieCompactionPlanGenerator.java:
##########
@@ -47,7 +47,7 @@ public HoodieCompactionPlanGenerator(HoodieTable table, HoodieEngineContext engi
BaseTableServicePlanActionExecutor executor) {
super(table, engineContext, writeConfig, executor);
this.compactionStrategy = writeConfig.getCompactionStrategy();
- log.info("Compaction Strategy used is: " + compactionStrategy.toString());
+ log.info("Compaction Strategy used is: {}", compactionStrategy.toString());
Review Comment:
π€ nit: `compactionStrategy.toString()` is redundant here too β `log.info("Compaction Strategy used is: {}", compactionStrategy)` is all you need.
<sub><i>β οΈ AI-generated; verify before applying. React π/π to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/LSMTimelineWriter.java:
##########
@@ -136,8 +137,9 @@ public void write(
throw new HoodieIOException("Failed to check archiving file before write: " + filePath, ioe);
}
try (HoodieFileWriter writer = openWriter(filePath)) {
- HoodieSchema schema = HoodieSchema.fromAvroSchema(HoodieLSMTimelineInstant.getClassSchema());
- log.info("Writing schema {}", schema);
+ Schema wrapperSchema = HoodieLSMTimelineInstant.getClassSchema();
+ log.info("Writing schema {}", wrapperSchema.toString());
Review Comment:
π€ nit: same as above β `wrapperSchema.toString()` is redundant with `{}`; `log.info("Writing schema {}", wrapperSchema)` would be sufficient.
<sub><i>β οΈ AI-generated; verify before applying. React π/π to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4875851290
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93db83836a12a39256b69b426984e3cab1a2bf72 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149)
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4881971473
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
}, {
"hash" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165",
"triggerID" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"triggerType" : "PUSH"
}, {
"hash" : "55b4be9efe3e88dbcba41f3ae2210dec6b17ac66",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15219",
"triggerID" : "55b4be9efe3e88dbcba41f3ae2210dec6b17ac66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* 55b4be9efe3e88dbcba41f3ae2210dec6b17ac66 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15219)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4875819331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93db83836a12a39256b69b426984e3cab1a2bf72 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4876535099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93db83836a12a39256b69b426984e3cab1a2bf72 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149)
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* c8a01457dc13d38a8e71582da61d8344c02ec481 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #19155:
URL: https://github.com/apache/hudi/pull/19155#discussion_r3520949752
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -109,8 +109,7 @@ public HoodieBinaryCopyHandle(
}
public void write() {
Review Comment:
π€ nit: the original two-line split was actually easier to read here β this line is now ~180+ chars. Could you keep the line break before the second sentence? e.g. `log.info("Start to merge source files {} into target file: {}.\n Please pay attention...", this.inputFiles, this.path);` or split the format string across lines.
<sub><i>β οΈ AI-generated; verify before applying. React π/π to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #19155:
URL: https://github.com/apache/hudi/pull/19155#discussion_r3522935234
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -109,8 +109,7 @@ public HoodieBinaryCopyHandle(
}
public void write() {
Review Comment:
Addressed - wrapped the statement so the format string is on one line and `this.inputFiles, this.path` on the next. Kept the logged message itself single-line rather than embedding a `\n` in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(client): use SLF4J parameterized logging instead of string concatenation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19155:
URL: https://github.com/apache/hudi/pull/19155#issuecomment-4881661450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15149",
"triggerID" : "93db83836a12a39256b69b426984e3cab1a2bf72",
"triggerType" : "PUSH"
}, {
"hash" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16ded7c31e4287470313d99ed025a4da0e0ae3c2",
"triggerType" : "PUSH"
}, {
"hash" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15153",
"triggerID" : "c8a01457dc13d38a8e71582da61d8344c02ec481",
"triggerType" : "PUSH"
}, {
"hash" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165",
"triggerID" : "38ebb72dedc8d0c11abdf4bcb24e296efef923c3",
"triggerType" : "PUSH"
}, {
"hash" : "55b4be9efe3e88dbcba41f3ae2210dec6b17ac66",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15219",
"triggerID" : "55b4be9efe3e88dbcba41f3ae2210dec6b17ac66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16ded7c31e4287470313d99ed025a4da0e0ae3c2 UNKNOWN
* 38ebb72dedc8d0c11abdf4bcb24e296efef923c3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15165)
* 55b4be9efe3e88dbcba41f3ae2210dec6b17ac66 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15219)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org