[GitHub] zachgk opened a new pull request #12017: Fix flaky tests for test_squared_hinge_loss

[GitBox <gi...@apache.org>]

zachgk opened a new pull request #12017: Fix flaky tests for test_squared_hinge_loss
URL: https://github.com/apache/incubator-mxnet/pull/12017
 
 
   ## Description ##
   Fix for issue [#11721](https://github.com/apache/incubator-mxnet/issues/11702) -- Removing fixed seed as the flakiness is not reproducible
   
   Ran `tests/python/unittest/test_loss.py:test_squared_hinge_loss` and `tests/python/gpu/test_operator_gpu.py:test_squared_hinge_loss` 10k times each
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x ] Changes are complete (i.e. I finished coding on this PR)
   - [ x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x ] Remove fixed seed for test_loss.py:test_squared_hinge_loss
   
   ## Comments ##
   CPU Run:
   ```
   ubuntu@ip-172-31-27-232:~/incubator-mxnet$ MXNET_TEST_COUNT=10000 nosetests --logging-level=DEBUG --verbose -s tests/python/unittest/test_loss.py:test_squared_hinge_loss
   
   [DEBUG] 9999 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=711236678 to reproduce.
   [DEBUG] 10000 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1402836224 to reproduce.
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 7828.158s
   
   OK
   ```
   
   GPU Run:
   ```
   ubuntu@ip-172-31-27-232:~/incubator-mxnet$ MXNET_TEST_COUNT=10000 nosetests --logging-level=DEBUG --verbose -s tests/python/gpu/test_operator_gpu.py:test_squared_hinge_loss
   
   [DEBUG] 9999 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=330147794 to reproduce.
   [DEBUG] 10000 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=608869560 to reproduce.
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 8022.626s
   
   OK
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services