You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/08/16 18:22:46 UTC
[commons-crypto] branch master updated: SpotBugs replaced FindBugs
which is configured feom the site resources folder.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git
The following commit(s) were added to refs/heads/master by this push:
new 9b1b14c SpotBugs replaced FindBugs which is configured feom the site resources folder.
9b1b14c is described below
commit 9b1b14c87a300ab3d6ee55e1a2e6efd179f64808
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Aug 16 14:22:39 2020 -0400
SpotBugs replaced FindBugs which is configured feom the site resources
folder.
---
findbugs-exclude.xml | 64 ----------------------------------------------------
src/assembly/src.xml | 1 -
2 files changed, 65 deletions(-)
diff --git a/findbugs-exclude.xml b/findbugs-exclude.xml
deleted file mode 100644
index 29f446a..0000000
--- a/findbugs-exclude.xml
+++ /dev/null
@@ -1,64 +0,0 @@
-<?xml version="1.0"?>
-<!--
- Licensed to the Apache Software Foundation (ASF) under one or more
- contributor license agreements. See the NOTICE file distributed with
- this work for additional information regarding copyright ownership.
- The ASF licenses this file to You under the Apache License, Version 2.0
- (the "License"); you may not use this file except in compliance with
- the License. You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
--->
-
-<FindBugsFilter>
-
- <Match>
- <!--
- DC: Possible double check of field
- DE: Method might ignore exception
- DLS: Dead store to local variable
- Dm: Reliance on default encoding
- DP: Method invoked that should be only be invoked inside a doPrivileged block
- EI: May expose internal representation by returning reference to mutable object
- Eq: Class defines compareTo(...) and uses Object.equals()
- IS: Inconsistent synchronization
- JLM: Synchronization performed on util.concurrent instance
- LI: Incorrect lazy initialization of static field
- Nm: Very confusing method names
- NP: Load of known null value
- PT: Absolute path traversal in servlet
- PZLA: Consider returning a zero length array rather than null
- RCN: Redundant nullcheck of value known to be null
- REC: Exception is caught when Exception is not thrown
- RR: Method ignores results of InputStream.skip()
- RV: Method ignores exceptional return value
- SBSC: Method concatenates strings using + in a loop
- Se: Transient field of class that isn't Serializable
- SIC: Could be refactored into a named static inner class
- UC: Useless non-empty void method
- UPM: Private method is never called
- -->
- <Bug code="DC,DE,DLS,Dm,DP,EI,Eq,IS,JLM,LI,Nm,NP,PT,PZLA,RCN,REC,RR,RV,SBSC,Se,SIC,UC,UPM"/>
- </Match>
-
- <Match>
- <!-- This Match uses the BUG_PATTERN for matching.
-
- URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD: allow unread public/protected variables, but not private ones
- UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD: allow unused public/protected variables, but not private ones
-
- -->
- <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD,UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD"/>
- </Match>
-
- <Match>
- <Class name="org.apache.commons.crypto.NativeCodeLoader" />
- <Method name="extractLibraryFile" />
- <Bug pattern="OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE" />
- </Match>
-</FindBugsFilter>
-
diff --git a/src/assembly/src.xml b/src/assembly/src.xml
index 141fe05..d9370f0 100644
--- a/src/assembly/src.xml
+++ b/src/assembly/src.xml
@@ -28,7 +28,6 @@
<include>BUILDING.txt</include>
<include>checkstyle.xml</include>
<include>CONTRIBUTING.md</include>
- <include>findbugs-exclude.xml</include>
<include>LICENSE.txt</include>
<include>Makefile</include>
<include>Makefile.common</include>