You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Paul King <pa...@asert.com.au> on 2018/05/03 08:49:06 UTC

[VOTE] Release Apache Groovy 2.5.0-rc-2

Dear development community,

I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release!

This release includes 16 bug fixes/improvements as outlined in the
changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12343030

Tag:
https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_5_0_RC_2
Tag commit id: 9ffe537eaa88ac6d944a4d3d8cd20c8cda86bc98

The artifacts to be voted on are located as follows (r26677).
Source release:
https://dist.apache.org/repos/dist/dev/groovy/2.5.0-rc-2/sources
Convenience binaries:
https://dist.apache.org/repos/dist/dev/groovy/2.5.0-rc-2/distribution

Release artifacts are signed with a key from the following file:
https://dist.apache.org/repos/dist/dev/groovy/KEYS

Please vote on releasing this package as Apache Groovy 2.5.0-rc-2.

Reminder on ASF release approval requirements for PMC members:
http://www.apache.org/legal/release-policy.html#release-approval
Hints on validating checksums/signatures (but replace md5sum with
sha256sum):
https://www.apache.org/info/verification.html

The vote is open for the next 72 hours and passes if a majority of at least
three +1 PMC votes are cast.

[ ] +1 Release Apache Groovy 2.5.0-rc-2
[ ]  0 I don't have a strong opinion about this, but I assume it's ok
[ ] -1 Do not release Apache Groovy 2.5.0-rc-2 because...

Here is my vote:

+1 (binding)

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Posted by Russel Winder <ru...@winder.org.uk>.
[…]
> > 
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> > 
> > [ ] +1 Release Apache Groovy 2.5.0-rc-2
> > [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> > [ ] -1 Do not release Apache Groovy 2.5.0-rc-2 because...
> > 

+1 

-- 
Russel.
==========================================
Dr Russel Winder      t: +44 20 7585 2200
41 Buckmaster Road    m: +44 7770 465 077
London SW11 1EN, UK   w: www.russel.org.uk

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Posted by Remko Popma <re...@gmail.com>.
+1

On Thu, May 3, 2018 at 6:52 PM, John Wagenleitner <
john.wagenleitner@gmail.com> wrote:

> +1 (binding)
>
> On Thu, May 3, 2018 at 1:49 AM, Paul King <pa...@asert.com.au> wrote:
>
>>
>> Dear development community,
>>
>> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release!
>>
>> This release includes 16 bug fixes/improvements as outlined in the
>> changelog:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12318123&version=12343030
>>
>> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag
>> ;h=refs/tags/GROOVY_2_5_0_RC_2
>> Tag commit id: 9ffe537eaa88ac6d944a4d3d8cd20c8cda86bc98
>>
>> The artifacts to be voted on are located as follows (r26677).
>> Source release: https://dist.apache.org/repos/
>> dist/dev/groovy/2.5.0-rc-2/sources
>> Convenience binaries: https://dist.apache.org/repos/
>> dist/dev/groovy/2.5.0-rc-2/distribution
>>
>> Release artifacts are signed with a key from the following file:
>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>
>> Please vote on releasing this package as Apache Groovy 2.5.0-rc-2.
>>
>> Reminder on ASF release approval requirements for PMC members:
>> http://www.apache.org/legal/release-policy.html#release-approval
>> Hints on validating checksums/signatures (but replace md5sum with
>> sha256sum):
>> https://www.apache.org/info/verification.html
>>
>> The vote is open for the next 72 hours and passes if a majority of at
>> least three +1 PMC votes are cast.
>>
>> [ ] +1 Release Apache Groovy 2.5.0-rc-2
>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>> [ ] -1 Do not release Apache Groovy 2.5.0-rc-2 because...
>>
>> Here is my vote:
>>
>> +1 (binding)
>>
>>
>

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Posted by John Wagenleitner <jo...@gmail.com>.
+1 (binding)

On Thu, May 3, 2018 at 1:49 AM, Paul King <pa...@asert.com.au> wrote:

>
> Dear development community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release!
>
> This release includes 16 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12343030
>
> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_5_0_RC_2
> Tag commit id: 9ffe537eaa88ac6d944a4d3d8cd20c8cda86bc98
>
> The artifacts to be voted on are located as follows (r26677).
> Source release: https://dist.apache.org/repos/dist/dev/groovy/2.5.0-rc-2/
> sources
> Convenience binaries: https://dist.apache.org/repos/
> dist/dev/groovy/2.5.0-rc-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.5.0-rc-2.
>
> Reminder on ASF release approval requirements for PMC members:
> http://www.apache.org/legal/release-policy.html#release-approval
> Hints on validating checksums/signatures (but replace md5sum with
> sha256sum):
> https://www.apache.org/info/verification.html
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.5.0-rc-2
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-rc-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Posted by Guillaume Laforge <gl...@gmail.com>.
+1 (binding)

Ran all the tests successfully, and also did my usual smoke tests with the
Groovy Console.
All went perfectly fine.

Guillaume

On Thu, May 3, 2018 at 10:49 AM, Paul King <pa...@asert.com.au> wrote:

>
> Dear development community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release!
>
> This release includes 16 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12343030
>
> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_5_0_RC_2
> Tag commit id: 9ffe537eaa88ac6d944a4d3d8cd20c8cda86bc98
>
> The artifacts to be voted on are located as follows (r26677).
> Source release: https://dist.apache.org/repos/dist/dev/groovy/2.5.0-rc-2/
> sources
> Convenience binaries: https://dist.apache.org/repos/
> dist/dev/groovy/2.5.0-rc-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.5.0-rc-2.
>
> Reminder on ASF release approval requirements for PMC members:
> http://www.apache.org/legal/release-policy.html#release-approval
> Hints on validating checksums/signatures (but replace md5sum with
> sha256sum):
> https://www.apache.org/info/verification.html
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.5.0-rc-2
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-rc-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>


-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Twitter: @glaforge <http://twitter.com/glaforge>

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Posted by Daniel Sun <re...@hotmail.com>.
Hi  Cédric,

  `org.codehaus.groovy.runtime.memoize.MemoizeTest#testMemoizeConcurrently`
should be fixed now.

   Here is the relevant commit:
https://github.com/apache/groovy/commit/639264e7fe9ed44f0b81266a24748e09c6d0b921

Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Posted by Cédric Champeau <ce...@gmail.com>.
+1, even though some tests are not passing, see below, I think we should
take a look at them

gradle -b wrapper.gradle wrapper : ok
./gradlew clean dist: ok (https://scans.gradle.com/s/c7jwthugis7b2, we
seriously need to do something for the performance of Groovydoc...)
./gradlew testAll: ko (https://scans.gradle.com/s/wkyfhscuyzipy/tests/failed
)

Checksum ok:

$ sha256sum apache-groovy-src-2.5.0-rc-2.zip | cut -d" " -f1 | diff -
apache-groovy-src-2.5.0-rc-2.zip.sha256

< 913c59763d395d5e3cdd8296342f635d0a6786665b00b300149b06153364d9be
---
> 913c59763d395d5e3cdd8296342f635d0a6786665b00b300149b06153364d9be

Signature ok:

$ gpg --verify apache-groovy-src-2.5.0-rc-2.zip.asc
gpg: assuming signed data in `apache-groovy-src-2.5.0-rc-2.zip'
gpg: Signature made Thu 03 May 2018 09:40:34 AM CEST using RSA key ID
0FB1CD0B
gpg: Good signature from "Paul King <pa...@apache.org>"
gpg:                 aka "Paul King <pa...@asert.com.au>"
gpg:                 aka "Paul King <pa...@gmail.com>"
gpg:                 aka "Paul King <ki...@ociweb.com>"
gpg:                 aka "keybase.io/paulk_asert <pa...@keybase.io>"
...


2018-05-03 10:49 GMT+02:00 Paul King <pa...@asert.com.au>:

>
> Dear development community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release!
>
> This release includes 16 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12343030
>
> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_5_0_RC_2
> Tag commit id: 9ffe537eaa88ac6d944a4d3d8cd20c8cda86bc98
>
> The artifacts to be voted on are located as follows (r26677).
> Source release: https://dist.apache.org/repos/dist/dev/groovy/2.5.0-rc-2/
> sources
> Convenience binaries: https://dist.apache.org/repos/
> dist/dev/groovy/2.5.0-rc-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.5.0-rc-2.
>
> Reminder on ASF release approval requirements for PMC members:
> http://www.apache.org/legal/release-policy.html#release-approval
> Hints on validating checksums/signatures (but replace md5sum with
> sha256sum):
> https://www.apache.org/info/verification.html
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.5.0-rc-2
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-rc-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Posted by Daniel Sun <re...@hotmail.com>.
+1

All tests pass, and I built groovy from source code and tested groovy
console via the following code, which runs well.

```
class A {
    enum E { E1, E2 }
}
class B extends A {
    E e1() { E.E1 }
    E e2() { E.E2 }
}

def b = new B()
assert A.E.E1 == b.e1()
assert A.E.E2 == b.e2()
```

Here is my machine info:
------------------------------------------------------------
Gradle 4.7
------------------------------------------------------------

Build time:   2018-04-18 09:09:12 UTC
Revision:     b9a962bf70638332300e7f810689cb2febbd4a6c

Groovy:       2.4.12
Ant:          Apache Ant(TM) version 1.9.9 compiled on February 2 2017
JVM:          1.8.0_152 (Oracle Corporation 25.152-b16)
OS:           Windows 10 10.0 amd64


Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html