You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Jonathan Coveney (Created) (JIRA)" <ji...@apache.org> on 2011/11/17 05:16:51 UTC

[jira] [Created] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
-----------------------------------------------------------------------------------

                 Key: PIG-2379
                 URL: https://issues.apache.org/jira/browse/PIG-2379
             Project: Pig
          Issue Type: Bug
    Affects Versions: 0.10, 0.9.2, 0.11
            Reporter: Jonathan Coveney
            Assignee: Jonathan Coveney
             Fix For: 0.11


If you do this:
Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
System.out.println(s1.equals(s2)); //false!!

That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.

I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney updated PIG-2379:
----------------------------------

    Attachment: PIG2379.patch
    
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch, PIG2379.patch, PIG2379.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Dmitriy V. Ryaboy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154308#comment-13154308 ] 

Dmitriy V. Ryaboy commented on PIG-2379:
----------------------------------------

Jonathan, can you regenerate patch with "-w" (skip whitespace-only changes)?  Makes it easier to review.

If you like, open another ticket to fix whitespace ...

D
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158632#comment-13158632 ] 

Daniel Dai commented on PIG-2379:
---------------------------------

PIG2379_2.patch committed to trunk/0.10/0.9.
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.10, 0.9.2, 0.11
>
>         Attachments: PIG2379.patch, PIG2379_1.patch, PIG2379_2.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney updated PIG-2379:
----------------------------------

    Status: Patch Available  (was: Open)

Only ant test-committed on 11, probably would work on the rest
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch, PIG2379.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-2379:
----------------------------

    Attachment: PIG2379_2.patch

TestResourceSchema.testToPigSchemaWithTwoLevelAccess fail after patch checkin. Attach patch PIG2379_2.patch.
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.10, 0.9.2, 0.11
>
>         Attachments: PIG2379.patch, PIG2379_1.patch, PIG2379_2.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Dmitriy V. Ryaboy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-2379:
-----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

+1

committed to trunk.
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch, PIG2379_1.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney updated PIG-2379:
----------------------------------

    Attachment: PIG2379.patch

got rid of an unnecessary comment
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch, PIG2379.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney updated PIG-2379:
----------------------------------

    Attachment: PIG2379.patch
    
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Dmitriy V. Ryaboy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-2379:
-----------------------------------

    Fix Version/s: 0.9.2
                   0.10

Also committed to 0.9.2 and 0.10
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.10, 0.9.2, 0.11
>
>         Attachments: PIG2379.patch, PIG2379_1.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney updated PIG-2379:
----------------------------------

    Attachment:     (was: PIG2379.patch)
    
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Dmitriy V. Ryaboy (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy closed PIG-2379.
----------------------------------

    
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.10, 0.9.2, 0.11
>
>         Attachments: PIG2379.patch, PIG2379_1.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney updated PIG-2379:
----------------------------------

    Attachment: PIG2379_1.patch

good call, dmitriy. this has no whitespace changes (which themselves were largely a byproduct of my vim settings)
                
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch, PIG2379_1.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2379) Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access

Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Coveney updated PIG-2379:
----------------------------------

    Attachment: PIG2379.patch
    
> Bug in Schema.getPigSchema(ResourceSchema rSchema) improperly adds two level access
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-2379
>                 URL: https://issues.apache.org/jira/browse/PIG-2379
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.9.2, 0.11
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.11
>
>         Attachments: PIG2379.patch
>
>
> If you do this:
> Schema s1=Utils.getSchemaFromString("b:bag{t:tuple(name:chararray,age:int)}");
> Schema s2=Schema.getPigSchema(new ResourceSchema(s1));
> System.out.println(s1.equals(s2)); //false!!
> That's super weird! The reason is that getPigSchema was setting two level access to true for bags. I added a test, and deleted the piece that set it. I worked with trunk, but a cursory glance makes it appear that it should be able to work with other versions as well, as I don't think that code has changed for a while. I ran test-commit without issue, but haven't ran the full test suite.
> I appreciate any feedback on this!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira