You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Forrest Xia (JIRA)" <de...@geronimo.apache.org> on 2009/05/06 17:59:31 UTC
[jira] Created: (DAYTRADER-68) A version of daytrader for Tomcat 6
A version of daytrader for Tomcat 6
-----------------------------------
Key: DAYTRADER-68
URL: https://issues.apache.org/jira/browse/DAYTRADER-68
Project: DayTrader
Issue Type: New Feature
Security Level: public (Regular issues)
Components: Web Tier
Affects Versions: 2.2
Environment: Tomcat 6.0.18
Reporter: Forrest Xia
Assignee: Forrest Xia
I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709912#action_12709912 ]
Donald Woods commented on DAYTRADER-68:
---------------------------------------
Wondering why there are dependencies like openjpa, geronimo specs, ... in the pom.xml, but none are pulled into the created WAR file?
Also, please update the README with instructions on how to deploy to Tomcat and Little-G. Thanks.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709907#action_12709907 ]
Donald Woods commented on DAYTRADER-68:
---------------------------------------
Forrest, can you describe how this version of Daytrader differs from the normal one?
What changes did you make to remove the EJB/JPA dependencies?
Any thoughts of using non-container managed JPA w/o the need for EJBs for the DB access?
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709873#action_12709873 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
I decided to go ahead and checkin the code so that further collaboration could take place in svn. I added the missing headers, fixed the build, included commons-logging in the war (not included in tomcat 6 and decided it was better in the war than manually pulling it into tomcat) and beautified some code.
Included in trunk rev. 775187
Still needed is to create plugins for Geronimo jetty and tomcat. We also need to reconcile the datasource issues for Geronimo (perhaps we can share a common datasource with the full sample).
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708034#action_12708034 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
Another issue: Although there are some problems with building daytrader trunk without this patch applied once it is applied there is a new problem:
Project 'org.apache.geronimo.daytrader:daytrader-web' is duplicated in the reactor
Looks like there is a conflict because we now have to projects named daytrader-web - the original one under modules/web/ and the new one.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia updated DAYTRADER-68:
---------------------------------
Attachment: daytrader-webonly-updated.patch
Except the 5th item, all of remained todo items are done with the new patch "daytrader-webonly-updated.patch":
1. Remove unnecessary dependencies of daytrader web only version
2. Update README to better decribe the differences from the formal version
3. Add two plugins for Tomcat and Jetty respectively for web only version
4. Update daytrader trunk to use Jetty7
Please check and help commit, thanks!
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly-updated.patch, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn resolved DAYTRADER-68.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.2
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia updated DAYTRADER-68:
---------------------------------
Attachment: daytrader-webonly-new.zip
Hi Joe, I just realized the zip file includes many .svn hidden directories, so please use the new zip file. Thanks!
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710753#action_12710753 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
Donald,
Can you clarify your comments regarding geronimo plugins? Daytrader trunk already creates several plugins for both tomcat and jetty (streamer-client, ws-client, and the core sample itself) along with plugins for various datasources and jms. In fact, I think these were part of the 2.1.3 release you had assembled and put up for vote a few months back. Introducing a web-only version of the core sample and making plugins for it available for tomcat and jetty seems consistent with what is already in place. I see no reason to extract the plugin generation from Daytrader and include it in Geronimo Samples. If daytrader is to be a subproject of Geronimo then it seems appropriate that it would contain some Geronimo specific content. However, I would hope that the addition of Geronimo plugins would not hinder our ability to generate the vanilla war/ear versions for deployment in other web/app servers since that is my current interest at the moment.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710356#action_12710356 ]
Donald Woods commented on DAYTRADER-68:
---------------------------------------
Not sure how we could do #1 (remove depends) if you truly want this to be a web-only project. Seems that if this is targeted for servlet containers (like stand-alone Tomcat 6 or Jetty) then you would need to include the depends. Yet again, I think we have a disconnect between the goals of the code and some community members' goal of turning everything into a plugin. Daytrader is not currently part of the Geronimo Samples (is released on its own) so any build setup to create plugins should be over in the Geronimo Samples project and we should leave the Daytrader code deployable on other web/app servers, which was the original goal of the subproject.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706578#action_12706578 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
Hi Forrest,
I attempted to apply this patch locally but encountered some problems due to inconsistent line-endings on the files. I think the problem is related to not having the right config setting for svn. Please reference http://cwiki.apache.org/GMOxDEV/subversion-client-configuration.html and after making the appropriate changes generate a new patch.
Thanks, Joe
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751486#action_12751486 ]
Donald Woods commented on DAYTRADER-68:
---------------------------------------
The new web-only plugins should go under -
daytrader/trunk/assemblies/web/plugins
and have names that match the WAR it is turning into a Geronimo Plugin, like -
web/daytrader-web-jdbc -> plugins/daytrader-web-jdbc-tomcat
as hopefully I'll get back to creating a daytrader-web-jpa version of the web assembly later next week.
Also, I could use you help to finish updating and testing the assemblies/javaee files (war, ear, plugins, plans), as I have not had time to look at those yet.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly-updated.patch, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707533#action_12707533 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
Hi Forrest,
That definitely fixed the line-ending issues. However, I think we still need some more work to this patch before we apply it.
It is named as being a web-only version of daytrader but it is also tomcat specific. There was discussion when this was first proposed that we should support both jetty and tomcat. If we cannot have a single generic version than we should perhaps create two webonly versions - one for tomcat and one for jetty. I wonder if we can configure this something like the console so that we can have a generic war and then tomcat and jetty specific plugins for easy installation. We need to think about this some more ... but I wanted to post the concern so you were aware of the issue.
Thanks, Joe
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia updated DAYTRADER-68:
---------------------------------
Attachment: daytrader-web-jdbc.patch
The new patch for restructured daytrader source code tree. Please check and commit. thanks!
Sure, we will take time to test restructured daytrader, including javaee/web-jdbc/web-jpa/ assemblies.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-web-jdbc.patch, daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly-updated.patch, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710795#action_12710795 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
I agree that we shouldn't break the non-plugin install. What is currently in trunk installs in tomcat as-is. I updated the build so that commons-logging is included in the war's web-inf/lib. The only other dependency that must be manually placed in the tomcat/lib is the derby jar ... at least that worked for me.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751330#action_12751330 ]
Forrest Xia commented on DAYTRADER-68:
--------------------------------------
Yes, it's patch for trunk in the old structure.
I will create another patch for the new structure soon.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly-updated.patch, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia updated DAYTRADER-68:
---------------------------------
Attachment: daytrader-webonly.zip
daytrader-webonly-new.patch
I double check my .subversion/config, it is really set as same as the link you pointed. (Donald ever guided me to set it :), but when I add those sources, it really warned me about EOL. Strangely, my working box is linux, how do those windows EOLs appear in files?
Anyway, I use dos2unix to convert all files in daytrader-webonly, and then generate a new patch. Also I attach a local zip file in case there are some GIF files missing when you are doing commit.
Thank you Joe for your quick review and commit!
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly-new.patch, daytrader-webonly.patch, daytrader-webonly.zip
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia updated DAYTRADER-68:
---------------------------------
Attachment: (was: daytrader-webonly.zip)
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708651#action_12708651 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
Some more comments and questions:
- I noticed that ./daytrader-webonly/daytrader-datasource-plan.xml and ./daytrader-webonly/src/main/webapp/META-INF/context.xml are missing the Apache License header. Can you please add them with your contribution?
- We probably need some more description (in the README?) about the datasource and how to handle this for Geronimo installations and possibly Tomcat installs as well. I can see where it might be confusing with the daytrader-derby-datasource that we also have out there. Perhaps we need to include webonly in this name as well.
- were you working on the tomcat/jetty plugins of this that were discussed on the original proposal?
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751011#action_12751011 ]
Joe Bohn commented on DAYTRADER-68:
-----------------------------------
Forrest,
Is this a patch for trunk? Was it created after the most recent structure changes? I believe that the /daytrader-webonly/ directory and it's contents are all but physically removed from svn now and has been replaced with /assemblies/web/daytrader-web-jdbc/
Joe
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly-updated.patch, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia updated DAYTRADER-68:
---------------------------------
Attachment: daytrader-webonly.patch
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Forrest Xia
> Attachments: daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Forrest Xia (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710173#action_12710173 ]
Forrest Xia commented on DAYTRADER-68:
--------------------------------------
Joe, Donald, thank you for your review, commit, and comments for next step. I know there is more work to do :-)
Summarizing the comments from Joe and Donald, here is my understanding about what to do next:
1. Revise the pom.xml to remove the dependencies like openjpa, geronimo specs, etc.
2. Have a generic version of daytrader-webonly for both tomcat and jetty
3. Have two plugins of daytrader-webonly, one for geronimo tomcat version, another for geronimo jetty version
4. More doc work
4.1 about difference between daytrader-webonly version and the normal one
4.2 about how to deploy to tomcat and little-g
5. Investigate non-container managed JPA for db access
I will try best to followup this list asap. If anything I misundertood or missed, feel free to comment on this jira. thanks!
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DAYTRADER-68) A version of daytrader for Tomcat 6
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn reassigned DAYTRADER-68:
---------------------------------
Assignee: Joe Bohn (was: Forrest Xia)
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-68) A version of daytrader for Tomcat
6
Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710790#action_12710790 ]
Donald Woods commented on DAYTRADER-68:
---------------------------------------
If we can generate non-plugin artifacts without duplicating modules, then great. I just don't want us creating a plugin-only or crippled plug-in ready version of the web-only code, as it should also be deployable in Tomcat AS-IS with all the required depends (except the DB) contained in the webapps /lib directory, instead of expecting users to copy depends into Tomcats lib or shared directories.
> A version of daytrader for Tomcat 6
> -----------------------------------
>
> Key: DAYTRADER-68
> URL: https://issues.apache.org/jira/browse/DAYTRADER-68
> Project: DayTrader
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Web Tier
> Affects Versions: 2.2
> Environment: Tomcat 6.0.18
> Reporter: Forrest Xia
> Assignee: Joe Bohn
> Fix For: 2.2
>
> Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to daytrader trunk, please help review and commit. thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.