[jira] [Commented] (LIBCLOUD-867) Support new ebs storage types in ec2 driver

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612824#comment-15612824 ] 

ASF GitHub Bot commented on LIBCLOUD-867:
-----------------------------------------

GitHub user smgoller opened a pull request:

    https://github.com/apache/libcloud/pull/925

    [LIBCLOUD-867] Add st1 and sc1 volume types to valid types

    ## Add additional supported storage types to create_volume
    
    ### Description
    
    EC2 supports additional storage types geared toward throughput and cold storage. We have a need for the cold storage volume type but libcloud currently doesn't support it. It seemed a good idea to just put up a pull request for this instead of asking for the change since it's so small.
    
    We didn't feel there was a need to create a test for this change, nor additional documentation examples. If this is not the case we can add them.
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [*] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smgoller/libcloud LIBCLOUD-867

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/925.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #925
    
----
commit 9fd9dbd5a519b6eb476e593b525ee86e7f79213e
Author: Sean Goller <se...@goller.net>
Date:   2016-10-27T18:48:53Z

    [LIBCLOUD-867] Add st1 and sc1 volume types to valid types

----


> Support new ebs storage types in ec2 driver
> -------------------------------------------
>
>                 Key: LIBCLOUD-867
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-867
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Sean Goller
>
> The list of valid ebs storage types in the BaseEC2NodeDriver class is as follows:
> bq. {{valid_volume_types = ['standard', 'io1', 'gp2']}}
> EC2 also supports st1 (throughput) and sc1 (cold storage) types. They should be added to the list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)