You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/20 15:41:46 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2245: STM32 Allow
reboot to bootloader
kasjer opened a new pull request #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245
STM32 MCUs have embedded bootloader that can be activated on reset when BOOT pin(s) are in certain state.
This change allows to start bootloader from application that is running from flash, so bootloader can be activated even if BOOT pins are soldered to boot system from flash.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] kasjer merged pull request #2245: STM32 Allow reboot
to bootloader
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2245:
STM32 Allow reboot to bootloader
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601770523
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/mcu/stm/stm32_common/src/stm32_bootloader.c
<details>
```diff
@@ -1,4 +1,3 @@
-
#include <stdint.h>
#include <mcu/stm32_hal.h>
#include <mcu/mcu.h>
@@ -22,5 +21,5 @@
system_memory_reset_handler = (void (*)(void))(system_memory[1]);
system_memory_reset_handler();
- while(1) ;
+ while (1);
}
```
</details>
#### hw/mcu/stm/stm32f1xx/include/mcu/mcu.h
<details>
```diff
@@ -34,10 +34,10 @@
defined(STM32F103x6) || defined(STM32F103xB) || defined(STM32F103xE)
#define STM32_SYSTEM_MEMORY 0x1FFFF000
#elif defined(STM32F105xC) || \
- defined(STM32F107xC)
+ defined(STM32F107xC)
#define STM32_SYSTEM_MEMORY 0x1FFFB000
#elif defined(STM32F101xG) || \
- defined(STM32F103xG)
+ defined(STM32F103xG)
#define STM32_SYSTEM_MEMORY 0x1FFFE000
#endif
```
</details>
#### hw/mcu/stm/stm32f4xx/include/mcu/mcu.h
<details>
```diff
@@ -31,7 +31,7 @@
defined(STM32F407xx) || \
defined(STM32F410Cx) || defined(STM32F410Rx) || defined(STM32F410Tx) || \
defined(STM32F411xE) || \
- defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx) || defined(STM32F412Zx) || \
+ defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx) || defined(STM32F412Zx) || \
defined(STM32F415xx) || \
defined(STM32F417xx) || \
defined(STM32F427xx) || \
```
</details>
#### hw/mcu/stm/stm32l0xx/include/mcu/mcu.h
<details>
```diff
@@ -26,7 +26,8 @@
#define SVC_IRQ_NUMBER SVC_IRQn
-#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || defined(STM32L010xB) || defined(STM32L011xx) || \
+#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || defined(STM32L010xB) || \
+ defined(STM32L011xx) || \
defined(STM32L021xx) || \
defined(STM32L031xx) || \
defined(STM32L041xx) || \
@@ -37,18 +38,18 @@
#define STM32_SYSTEM_MEMORY 0x1FF00000
#endif
- /*
+/*
* Defines for naming GPIOs.
*/
-#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
-#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
-#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
-#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
-#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
-#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
-#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
-#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
-#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
+#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
+#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
+#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
+#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
+#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
+#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
+#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
+#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
+#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
#ifdef __cplusplus
}
```
</details>
#### hw/mcu/stm/stm32l1xx/include/mcu/mcu.h
<details>
```diff
@@ -33,7 +33,8 @@
defined(STM32L151xD) || defined(STM32L151xDX) || defined(STM32L151xE) || \
defined(STM32L152xB) || defined(STM32L152xBA) || defined(STM32L152xC) || defined(STM32L152xCA) || \
defined(STM32L152xD) || defined(STM32L152xDX) || defined(STM32L152xE) || \
- defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) || defined(STM32L162xDX) || defined(STM32L162xE)
+ defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) || defined(STM32L162xDX) || \
+ defined(STM32L162xE)
#define STM32_SYSTEM_MEMORY 0x1FF00000
#endif
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] brianwyld commented on issue #2245: STM32 Allow
reboot to bootloader
Posted by GitBox <gi...@apache.org>.
brianwyld commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-603286496
Hi,
Does this mean it may have an impact on using HSE with STM32?
thanks
Brian
On Tue, 24 Mar 2020 at 14:57, Fabio Utzig <no...@github.com> wrote:
> *@utzig* approved this pull request.
>
> LGTM. I only tested this on Nucleo-F439ZI so far, it works well. A caveat
> is that I had to enable HSI (syscfg) otherwise the bootloader does not
> start. I will do a bit testing on other families, but proceed with merge.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/mynewt-core/pull/2245#pullrequestreview-380332819>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMIHRIAGV4YTVMAHVOKUSJTRJC33HANCNFSM4LQOWDBA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] brianwyld commented on issue #2245: STM32 Allow
reboot to bootloader
Posted by GitBox <gi...@apache.org>.
brianwyld commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-603294533
Ok, thanks!
On Tue, 24 Mar 2020 at 16:03, kasjer <no...@github.com> wrote:
> Hi, Does this mean it may have an impact on using HSE with STM32? thanks
> Brian
>
> Hi @brianwyld <https://github.com/brianwyld>, this is adds new function
> that can be used to start ST bootloader.
> If you don't use this function in your code, there is no impact.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/mynewt-core/pull/2245#issuecomment-603291372>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMIHRIA4C63VJZ6GEBAASJDRJDDTZANCNFSM4LQOWDBA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2245: STM32
Allow reboot to bootloader
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601771237
<!-- license-bot -->
## RAT Report (2020-03-20 15:49:17)
## New files with unknown licenses
* <a href="https://github.com/apache/mynewt-core/blob/94a2f8887d996417d2cf6183cea2df399c32bc32/hw/mcu/stm/stm32_common/src/stm32_bootloader.c">hw/mcu/stm/stm32_common/src/stm32_bootloader.c</a>
## 1 new files were excluded from check (.rat-excludes)
<details>
<summary>Detailed analysis</summary>
## New files in this PR
| License | File |
|---------|------|
| ????? | <a href="https://github.com/apache/mynewt-core/blob/94a2f8887d996417d2cf6183cea2df399c32bc32/hw/mcu/stm/stm32_common/src/stm32_bootloader.c">hw/mcu/stm/stm32_common/src/stm32_bootloader.c</a> |
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] kasjer commented on issue #2245: STM32 Allow reboot
to bootloader
Posted by GitBox <gi...@apache.org>.
kasjer commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-603291372
> Hi, Does this mean it may have an impact on using HSE with STM32? thanks Brian
Hi @brianwyld, this is adds new function that can be used to start ST bootloader.
If you don't use this function in your code, there is no impact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2245: STM32 Allow reboot to
bootloader
Posted by GitBox <gi...@apache.org>.
utzig commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-602593613
@kasjer This looks nice, I'm gonna try to test it this afternoon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2245: STM32
Allow reboot to bootloader
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601779251
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2245: STM32
Allow reboot to bootloader
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601770523
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/mcu/stm/stm32_common/src/stm32_bootloader.c
<details>
```diff
@@ -1,4 +1,3 @@
-
#include <stdint.h>
#include <mcu/stm32_hal.h>
#include <mcu/mcu.h>
@@ -22,5 +21,5 @@
system_memory_reset_handler = (void (*)(void))(system_memory[1]);
system_memory_reset_handler();
- while(1) ;
+ while (1);
}
```
</details>
#### hw/mcu/stm/stm32f1xx/include/mcu/mcu.h
<details>
```diff
@@ -34,10 +34,10 @@
defined(STM32F103x6) || defined(STM32F103xB) || defined(STM32F103xE)
#define STM32_SYSTEM_MEMORY 0x1FFFF000
#elif defined(STM32F105xC) || \
- defined(STM32F107xC)
+ defined(STM32F107xC)
#define STM32_SYSTEM_MEMORY 0x1FFFB000
#elif defined(STM32F101xG) || \
- defined(STM32F103xG)
+ defined(STM32F103xG)
#define STM32_SYSTEM_MEMORY 0x1FFFE000
#endif
```
</details>
#### hw/mcu/stm/stm32f4xx/include/mcu/mcu.h
<details>
```diff
@@ -31,7 +31,7 @@
defined(STM32F407xx) || \
defined(STM32F410Cx) || defined(STM32F410Rx) || defined(STM32F410Tx) || \
defined(STM32F411xE) || \
- defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx) || defined(STM32F412Zx) || \
+ defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx) || defined(STM32F412Zx) || \
defined(STM32F415xx) || \
defined(STM32F417xx) || \
defined(STM32F427xx) || \
```
</details>
#### hw/mcu/stm/stm32l0xx/include/mcu/mcu.h
<details>
```diff
@@ -26,7 +26,8 @@
#define SVC_IRQ_NUMBER SVC_IRQn
-#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || defined(STM32L010xB) || defined(STM32L011xx) || \
+#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || defined(STM32L010xB) || \
+ defined(STM32L011xx) || \
defined(STM32L021xx) || \
defined(STM32L031xx) || \
defined(STM32L041xx) || \
@@ -37,18 +38,18 @@
#define STM32_SYSTEM_MEMORY 0x1FF00000
#endif
- /*
+/*
* Defines for naming GPIOs.
*/
-#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
-#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
-#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
-#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
-#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
-#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
-#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
-#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
-#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
+#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
+#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
+#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
+#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
+#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
+#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
+#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
+#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
+#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
#ifdef __cplusplus
}
```
</details>
#### hw/mcu/stm/stm32l1xx/include/mcu/mcu.h
<details>
```diff
@@ -33,7 +33,8 @@
defined(STM32L151xD) || defined(STM32L151xDX) || defined(STM32L151xE) || \
defined(STM32L152xB) || defined(STM32L152xBA) || defined(STM32L152xC) || defined(STM32L152xCA) || \
defined(STM32L152xD) || defined(STM32L152xDX) || defined(STM32L152xE) || \
- defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) || defined(STM32L162xDX) || defined(STM32L162xE)
+ defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) || defined(STM32L162xDX) || \
+ defined(STM32L162xE)
#define STM32_SYSTEM_MEMORY 0x1FF00000
#endif
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services