[jira] [Comment Edited] (IGNITE-10748) Remove dead code in TcpCommunicationSpi for the tcp client creation flow

["Sergey Chugunov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759669#comment-16759669 ] 

Sergey Chugunov edited comment on IGNITE-10748 at 2/4/19 7:21 AM:
------------------------------------------------------------------

[~Mmuzaf],

Thanks for merging PR with master, I started reviewing it. Hopefully will finish the review in a day or two.


was (Author: sergey-chugunov):
[~Mmuzaf],

 

Thanks for merging PR with master, I started reviewing it. Hopefully will finish the review in a day or two.

> Remove dead code in TcpCommunicationSpi for the tcp client creation flow
> ------------------------------------------------------------------------
>
>                 Key: IGNITE-10748
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10748
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Minor
>             Fix For: 2.8
>
>
> Currently, a batch of changes can be applied over {{TcpCommunicationSpi}} class implementation due to:
> # {{safeTcpHandshake(..)}}
> #* {{handshakeConnIdx}} - parameter is always not null
> #* {{recovery}} - parameter is always not null
> #* {{HandhakeMessage}} - is not used in current flow at all
> # {{HandshakeMessage2}}
> #* Message size must be defined in the message class as constant
> # {{createTcpClient(..)}}
> #* Instantiation of {{GridTcpNioCommunicationClient}} must be performed outside the while-loop
> # Code-style issues. Fix one-liner if statements.
> # Extract internal {{HandshakeException}}, {{HandshakeTimeoutException}} from class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)