You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dawidwys (via GitHub)" <gi...@apache.org> on 2025/11/24 11:27:27 UTC
[PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
dawidwys opened a new pull request, #27265:
URL: https://github.com/apache/flink/pull/27265
## What is the purpose of the change
Validate timezone and pattern literals in TO_TIMESTAMP_LTZ
## Verifying this change
Edited tests in TimeFunctionsITCase
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2556341560
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2404,20 +2404,7 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
BuiltInFunctionDefinition.newBuilder()
.name("TO_TIMESTAMP_LTZ")
.kind(SCALAR)
- .inputTypeStrategy(
- or(
- sequence(logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(logical(LogicalTypeFamily.NUMERIC)),
Review Comment:
The SpecificInputTypeStrategies seems to only process when the first parameter is a string. I am wondering about the last 2 entries in this list that start with numbers. I am curious , have we lost support for these patterns with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27265:
URL: https://github.com/apache/flink/pull/27265#issuecomment-3570342099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e57d41aab719691d12982009761f15ee2ba01f26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e57d41aab719691d12982009761f15ee2ba01f26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e57d41aab719691d12982009761f15ee2ba01f26 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2556840636
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java:
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.types.inference.strategies;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.ArgumentCount;
+import org.apache.flink.table.types.inference.ArgumentTypeStrategy;
+import org.apache.flink.table.types.inference.CallContext;
+import org.apache.flink.table.types.inference.ConstantArgumentCount;
+import org.apache.flink.table.types.inference.InputTypeStrategy;
+import org.apache.flink.table.types.inference.Signature;
+import org.apache.flink.table.types.inference.Signature.Argument;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import java.time.DateTimeException;
+import java.time.ZoneId;
+import java.time.format.DateTimeFormatter;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+
+import static org.apache.flink.table.types.inference.InputTypeStrategies.logical;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.or;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.sequence;
+
+/**
+ * A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where the first argument is a
+ * string that needs to be parsed.
+ */
+@Internal
+public class ToTimestampLtzInputTypeStrategy implements InputTypeStrategy {
+
+ private static final ArgumentTypeStrategy CHARACTER_STRING_FAMILY_ARG =
Review Comment:
Correct, this checks only literals. For non-literals I left the behaviour unchanged.
There are tests covering both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2556840636
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java:
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.types.inference.strategies;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.ArgumentCount;
+import org.apache.flink.table.types.inference.ArgumentTypeStrategy;
+import org.apache.flink.table.types.inference.CallContext;
+import org.apache.flink.table.types.inference.ConstantArgumentCount;
+import org.apache.flink.table.types.inference.InputTypeStrategy;
+import org.apache.flink.table.types.inference.Signature;
+import org.apache.flink.table.types.inference.Signature.Argument;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import java.time.DateTimeException;
+import java.time.ZoneId;
+import java.time.format.DateTimeFormatter;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+
+import static org.apache.flink.table.types.inference.InputTypeStrategies.logical;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.or;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.sequence;
+
+/**
+ * A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where the first argument is a
+ * string that needs to be parsed.
+ */
+@Internal
+public class ToTimestampLtzInputTypeStrategy implements InputTypeStrategy {
+
+ private static final ArgumentTypeStrategy CHARACTER_STRING_FAMILY_ARG =
Review Comment:
Correct, this checks only literals. For non-literals I left the behaviour unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2556643620
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2404,20 +2404,7 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
BuiltInFunctionDefinition.newBuilder()
.name("TO_TIMESTAMP_LTZ")
.kind(SCALAR)
- .inputTypeStrategy(
- or(
- sequence(logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(logical(LogicalTypeFamily.NUMERIC)),
Review Comment:
No, please check it again. It also handles the other cases as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys merged PR #27265:
URL: https://github.com/apache/flink/pull/27265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2559231787
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2404,20 +2404,7 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
BuiltInFunctionDefinition.newBuilder()
.name("TO_TIMESTAMP_LTZ")
.kind(SCALAR)
- .inputTypeStrategy(
- or(
- sequence(logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING),
- logical(LogicalTypeFamily.CHARACTER_STRING)),
- sequence(logical(LogicalTypeFamily.NUMERIC)),
Review Comment:
@dawidwys I see now, I was mislead by the [comments](https://github.com/apache/flink/blob/1cc2f147ddf0ffd4ce37be7c6f55355cf34fa907/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java#L46)
```
* A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where the first argument is a
* string that needs to be parsed.
```
But in reality, if it is does not get a string it processes the numerics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #27265:
URL: https://github.com/apache/flink/pull/27265#issuecomment-3571423808
Based on CI failure you need to rebase to have green CI
it was fixed at [FLINK-38700](https://issues.apache.org/jira/browse/FLINK-38700)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38701] Validate timezone and pattern literals in TO_TIMESTAMP_LTZ [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #27265:
URL: https://github.com/apache/flink/pull/27265#discussion_r2556837218
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java:
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.types.inference.strategies;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.ArgumentCount;
+import org.apache.flink.table.types.inference.ArgumentTypeStrategy;
+import org.apache.flink.table.types.inference.CallContext;
+import org.apache.flink.table.types.inference.ConstantArgumentCount;
+import org.apache.flink.table.types.inference.InputTypeStrategy;
+import org.apache.flink.table.types.inference.Signature;
+import org.apache.flink.table.types.inference.Signature.Argument;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import java.time.DateTimeException;
+import java.time.ZoneId;
+import java.time.format.DateTimeFormatter;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+
+import static org.apache.flink.table.types.inference.InputTypeStrategies.logical;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.or;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.sequence;
+
+/**
+ * A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where the first argument is a
+ * string that needs to be parsed.
+ */
+@Internal
+public class ToTimestampLtzInputTypeStrategy implements InputTypeStrategy {
+
+ private static final ArgumentTypeStrategy CHARACTER_STRING_FAMILY_ARG =
Review Comment:
To double check: am I right that this will do checks only in planning
it means it will not catch cases like this
```sql
SELECT to_timestamp_ltz('1000-01-01 00:00:00', pattern, 'UTC') FROM (VALUES('unparsable')) AS t(pattern);
```
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzInputTypeStrategy.java:
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.types.inference.strategies;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.ArgumentCount;
+import org.apache.flink.table.types.inference.ArgumentTypeStrategy;
+import org.apache.flink.table.types.inference.CallContext;
+import org.apache.flink.table.types.inference.ConstantArgumentCount;
+import org.apache.flink.table.types.inference.InputTypeStrategy;
+import org.apache.flink.table.types.inference.Signature;
+import org.apache.flink.table.types.inference.Signature.Argument;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import java.time.DateTimeException;
+import java.time.ZoneId;
+import java.time.format.DateTimeFormatter;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+
+import static org.apache.flink.table.types.inference.InputTypeStrategies.logical;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.or;
+import static org.apache.flink.table.types.inference.InputTypeStrategies.sequence;
+
+/**
+ * A strategy for {@link BuiltInFunctionDefinitions#TO_TIMESTAMP_LTZ} where the first argument is a
+ * string that needs to be parsed.
+ */
+@Internal
+public class ToTimestampLtzInputTypeStrategy implements InputTypeStrategy {
+
+ private static final ArgumentTypeStrategy CHARACTER_STRING_FAMILY_ARG =
Review Comment:
To double check: am I right that this will do checks only in planning
it means it will not catch cases like this
```sql
SELECT to_timestamp_ltz('1000-01-01 00:00:00', pattern, 'UTC')
FROM (VALUES('unparsable')) AS t(pattern);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org