You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2018/06/04 08:55:26 UTC
[GitHub] brooklyn-docs pull request #256: BROOKLYN-588: add to troubleshooting for cu...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/256
BROOKLYN-588: add to troubleshooting for curl failure
See https://issues.apache.org/jira/browse/BROOKLYN-588
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs BROOKLYN-588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-docs/pull/256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #256
----
commit 55055c33235b1ece629afb7e4d40fbd60a1e06b7
Author: Aled Sage <al...@...>
Date: 2018-06-04T08:52:40Z
Fix/improve links
commit 093f483c133b856369afc2f7a7a2cdd9b1a74e4f
Author: Aled Sage <al...@...>
Date: 2018-06-04T08:54:11Z
BROOKLYN-588: add to troubleshooting for curl failure
See https://issues.apache.org/jira/browse/BROOKLYN-588
----
---
[GitHub] brooklyn-docs pull request #256: BROOKLYN-588: add to troubleshooting for cu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/256
---
[GitHub] brooklyn-docs pull request #256: BROOKLYN-588: add to troubleshooting for cu...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/256#discussion_r192688576
--- Diff: guide/ops/troubleshooting/connectivity.md ---
@@ -104,8 +104,8 @@ example, execute `sudo iptables -n --list` and `iptables -t nat -n --list`.
## Cloud firewalls
Some clouds offer a firewall service, where ports need to be explicitly listed to be reachable.
-For example, [security groups for EC2-classic]
-(http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html#ec2-classic-security-groups)
+For example,
+[security groups for EC2-classic](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html)
--- End diff --
Why did you removed the anchor here? It is still valid.
Having said that, the section doesn't seem to have specificities to firewalls. So the title probably need to change to `security groups for EC2`, or be dropped all together
---
[GitHub] brooklyn-docs pull request #256: BROOKLYN-588: add to troubleshooting for cu...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/256#discussion_r192878266
--- Diff: guide/ops/troubleshooting/connectivity.md ---
@@ -104,8 +104,8 @@ example, execute `sudo iptables -n --list` and `iptables -t nat -n --list`.
## Cloud firewalls
Some clouds offer a firewall service, where ports need to be explicitly listed to be reachable.
-For example, [security groups for EC2-classic]
-(http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html#ec2-classic-security-groups)
+For example,
+[security groups for EC2-classic](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html)
--- End diff --
Good spot. I removed the anchor because it's not just ec2-classic that is used in Brooklyn (one can point it at VPC security groups). Therefore I've changed the link text to 'security groups for AWS EC2'.
---