You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@kafka.apache.org by Dmitry Minkovsky <dm...@gmail.com> on 2017/12/17 22:31:53 UTC
Mistakes in documentation?
On https://docs.confluent.io/current/streams/developer-guide/dsl-api.html
for version 4.0.0:
Under "Table", currently:
> In the case of a KStream, the local KStream instance of every application
instance will be populated with data from only a subset of the partitions
of the input topic. Collectively, across all application instances, all
input topic partitions are read and processed.
Shouldn't it be KTable instead of KStream?
Also, under "GlobalKTable", current:
> In the case of a GlobalKTable, the local GlobalKTable instance of every
application instance will be populated with data from only a subset of the
partitions of the input topic. Collectively, across all application
instances, all input topic partitions are read and processed.
Shouldn't it say that all partitions are consumed by all instances of the
application?
Best,
Dmitry
Re: Mistakes in documentation?
Posted by Dmitry Minkovsky <dm...@gmail.com>.
Also the javadoc here:
https://github.com/apache/kafka/blob/e5daa40e316261e8e6cb8866ad9a4eedcf17f919/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java#L184-L185
Shouldn't it refer to the `Consumed`, given that it is provided in this
overload?
Sorry, I would post this to JIRA, but I couldn't find where. Maybe I don't
have privileges.
Dmitry
On Sun, Dec 17, 2017 at 5:31 PM, Dmitry Minkovsky <dm...@gmail.com>
wrote:
> On https://docs.confluent.io/current/streams/developer-guide/dsl-api.html
> for version 4.0.0:
>
> Under "Table", currently:
>
> > In the case of a KStream, the local KStream instance of every
> application instance will be populated with data from only a subset of the
> partitions of the input topic. Collectively, across all application
> instances, all input topic partitions are read and processed.
>
> Shouldn't it be KTable instead of KStream?
>
> Also, under "GlobalKTable", current:
>
> > In the case of a GlobalKTable, the local GlobalKTable instance of every
> application instance will be populated with data from only a subset of the
> partitions of the input topic. Collectively, across all application
> instances, all input topic partitions are read and processed.
>
> Shouldn't it say that all partitions are consumed by all instances of the
> application?
>
>
> Best,
> Dmitry
>
Re: Mistakes in documentation?
Posted by "Matthias J. Sax" <ma...@confluent.io>.
Thanks a lot!
On 12/18/17 12:46 PM, Dmitry Minkovsky wrote:
> You're welcome. Another one I found today
> https://docs.confluent.io/current/streams/developer-guide/dsl-api.html
>
>> groupedStream.windowedBy(TimeUnit.MINUTES.toMillis(5))
>
> should be
>
>> groupedStream.windowedBy(TimeWindows.of(TimeUnit.MINUTES.toMillis(5)))
>
> in two spots.
>
> On Mon, Dec 18, 2017 at 2:29 PM, Matthias J. Sax <ma...@confluent.io>
> wrote:
>
>> Thanks for reporting this!
>>
>> We will fix it.
>>
>> -Matthias
>>
>> On 12/17/17 7:05 PM, Philippe Derome wrote:
>>> I agree with Dmitry's first comment, it really looks like the paragraph
>> he
>>> points to under "Table" was pasted without edit from the one previously
>>> that pertained to "KStream".
>>>
>>> On Sun, Dec 17, 2017 at 5:31 PM, Dmitry Minkovsky <dm...@gmail.com>
>>> wrote:
>>>
>>>> On https://docs.confluent.io/current/streams/developer-
>> guide/dsl-api.html
>>>> for version 4.0.0:
>>>>
>>>> Under "Table", currently:
>>>>
>>>>> In the case of a KStream, the local KStream instance of every
>> application
>>>> instance will be populated with data from only a subset of the
>> partitions
>>>> of the input topic. Collectively, across all application instances, all
>>>> input topic partitions are read and processed.
>>>>
>>>> Shouldn't it be KTable instead of KStream?
>>>>
>>>> Also, under "GlobalKTable", current:
>>>>
>>>>> In the case of a GlobalKTable, the local GlobalKTable instance of every
>>>> application instance will be populated with data from only a subset of
>> the
>>>> partitions of the input topic. Collectively, across all application
>>>> instances, all input topic partitions are read and processed.
>>>>
>>>> Shouldn't it say that all partitions are consumed by all instances of
>> the
>>>> application?
>>>>
>>>>
>>>> Best,
>>>> Dmitry
>>>>
>>>
>>
>>
>
Re: Mistakes in documentation?
Posted by Dmitry Minkovsky <dm...@gmail.com>.
You're welcome. Another one I found today
https://docs.confluent.io/current/streams/developer-guide/dsl-api.html
> groupedStream.windowedBy(TimeUnit.MINUTES.toMillis(5))
should be
> groupedStream.windowedBy(TimeWindows.of(TimeUnit.MINUTES.toMillis(5)))
in two spots.
On Mon, Dec 18, 2017 at 2:29 PM, Matthias J. Sax <ma...@confluent.io>
wrote:
> Thanks for reporting this!
>
> We will fix it.
>
> -Matthias
>
> On 12/17/17 7:05 PM, Philippe Derome wrote:
> > I agree with Dmitry's first comment, it really looks like the paragraph
> he
> > points to under "Table" was pasted without edit from the one previously
> > that pertained to "KStream".
> >
> > On Sun, Dec 17, 2017 at 5:31 PM, Dmitry Minkovsky <dm...@gmail.com>
> > wrote:
> >
> >> On https://docs.confluent.io/current/streams/developer-
> guide/dsl-api.html
> >> for version 4.0.0:
> >>
> >> Under "Table", currently:
> >>
> >>> In the case of a KStream, the local KStream instance of every
> application
> >> instance will be populated with data from only a subset of the
> partitions
> >> of the input topic. Collectively, across all application instances, all
> >> input topic partitions are read and processed.
> >>
> >> Shouldn't it be KTable instead of KStream?
> >>
> >> Also, under "GlobalKTable", current:
> >>
> >>> In the case of a GlobalKTable, the local GlobalKTable instance of every
> >> application instance will be populated with data from only a subset of
> the
> >> partitions of the input topic. Collectively, across all application
> >> instances, all input topic partitions are read and processed.
> >>
> >> Shouldn't it say that all partitions are consumed by all instances of
> the
> >> application?
> >>
> >>
> >> Best,
> >> Dmitry
> >>
> >
>
>
Re: Mistakes in documentation?
Posted by "Matthias J. Sax" <ma...@confluent.io>.
Thanks for reporting this!
We will fix it.
-Matthias
On 12/17/17 7:05 PM, Philippe Derome wrote:
> I agree with Dmitry's first comment, it really looks like the paragraph he
> points to under "Table" was pasted without edit from the one previously
> that pertained to "KStream".
>
> On Sun, Dec 17, 2017 at 5:31 PM, Dmitry Minkovsky <dm...@gmail.com>
> wrote:
>
>> On https://docs.confluent.io/current/streams/developer-guide/dsl-api.html
>> for version 4.0.0:
>>
>> Under "Table", currently:
>>
>>> In the case of a KStream, the local KStream instance of every application
>> instance will be populated with data from only a subset of the partitions
>> of the input topic. Collectively, across all application instances, all
>> input topic partitions are read and processed.
>>
>> Shouldn't it be KTable instead of KStream?
>>
>> Also, under "GlobalKTable", current:
>>
>>> In the case of a GlobalKTable, the local GlobalKTable instance of every
>> application instance will be populated with data from only a subset of the
>> partitions of the input topic. Collectively, across all application
>> instances, all input topic partitions are read and processed.
>>
>> Shouldn't it say that all partitions are consumed by all instances of the
>> application?
>>
>>
>> Best,
>> Dmitry
>>
>
Re: Mistakes in documentation?
Posted by Philippe Derome <ph...@gmail.com>.
I agree with Dmitry's first comment, it really looks like the paragraph he
points to under "Table" was pasted without edit from the one previously
that pertained to "KStream".
On Sun, Dec 17, 2017 at 5:31 PM, Dmitry Minkovsky <dm...@gmail.com>
wrote:
> On https://docs.confluent.io/current/streams/developer-guide/dsl-api.html
> for version 4.0.0:
>
> Under "Table", currently:
>
> > In the case of a KStream, the local KStream instance of every application
> instance will be populated with data from only a subset of the partitions
> of the input topic. Collectively, across all application instances, all
> input topic partitions are read and processed.
>
> Shouldn't it be KTable instead of KStream?
>
> Also, under "GlobalKTable", current:
>
> > In the case of a GlobalKTable, the local GlobalKTable instance of every
> application instance will be populated with data from only a subset of the
> partitions of the input topic. Collectively, across all application
> instances, all input topic partitions are read and processed.
>
> Shouldn't it say that all partitions are consumed by all instances of the
> application?
>
>
> Best,
> Dmitry
>