You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/18 03:39:55 UTC

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #730: [Issue 729]stop ticker when create producer failed

wolfstudy commented on a change in pull request #730:
URL: https://github.com/apache/pulsar-client-go/pull/730#discussion_r809650637



##########
File path: pulsar/producer_partition.go
##########
@@ -145,6 +145,7 @@ func newPartitionProducer(client *client, topic string, options *ProducerOptions
 	}
 	err := p.grabCnx()
 	if err != nil {
+		p.batchFlushTicker.Stop()

Review comment:
       The `grabCnx()` is called in two places in total, except here in the`reconnectToBroker()` logic, it looks like we need the same fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org