You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/05/13 11:37:10 UTC

[GitHub] [brooklyn-server] zan-mateusz commented on pull request #1171: SMART-153 - Fixes around sealed/unavailable vault

zan-mateusz commented on pull request #1171:
URL: https://github.com/apache/brooklyn-server/pull/1171#issuecomment-840500264


   > code looks good to me. nice work.
   > 
   > not tested by me however.
   
   I have made some minor changes as discussed - formatting with IntelliJ (note couple of unrelated changes stemming from me using intelliJ reformatter, I considered them OK so left them in) - also changed method used for sleep between retries.
   
   The behaviour has been manually tested by me, I tried to play around with tests in VaultExternalConfigSupplierLiveTest but these require manual steps as well, automating this is painful and probably not worth the time investment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org