[GitHub] [spark] Yikun commented on a change in pull request #35663: [SPARK-37809] Add yunikorn feature step

[GitBox <gi...@apache.org>]

Yikun commented on a change in pull request #35663:
URL: https://github.com/apache/spark/pull/35663#discussion_r815549956



##########
File path: project/SparkBuild.scala
##########
@@ -968,6 +973,12 @@ object Volcano {
   )
 }
 
+object YuniKorn {
+  // Exclude all yunikorn file for Compile and Test
+  lazy val settings = Seq(
+    unmanagedSources / excludeFilter := HiddenFileFilter || "*YuniKorn*.scala")

Review comment:
       ```suggestion
       unmanagedSources / excludeFilter += HiddenFileFilter || "*YuniKorn*.scala")
   ```
   
   Looks like yunikorn setting overwrite accidently, try to use `+=` rather than `:=` in here.
   
   [1] https://www.scala-sbt.org/1.x/docs/Appending-Values.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org