You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2017/11/22 10:23:09 UTC
[jclouds/jclouds] [JCLOUDS-1360] add support for block device
mappings to Nova (#1159)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1159
-- Commit Summary --
* [JCLOUDS-1360] add support for block device mappings to Nova
-- File Changes --
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceAdapter.java (3)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.java (28)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1159.patch
https://github.com/jclouds/jclouds/pull/1159.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1159
Re: [jclouds/jclouds] [JCLOUDS-1360] add support for block device
mappings to Nova (#1159)
Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1159#pullrequestreview-78396614
Re: [jclouds/jclouds] [JCLOUDS-1360] add support for block device
mappings to Nova (#1159)
Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.
> @@ -131,7 +131,8 @@ public NovaComputeServiceAdapter(NovaApi novaApi, @Region Supplier<Set<String>>
if (templateOptions.getKeyPairName() != null) {
options.keyPairName(templateOptions.getKeyPairName());
}
-
+ if (!templateOptions.getBlockDeviceMappings().isEmpty()) options.blockDeviceMappings(templateOptions.getBlockDeviceMappings());
No need to check for empty.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1159#pullrequestreview-78396568
Re: [jclouds/jclouds] [JCLOUDS-1360] add support for block device
mappings to Nova (#1159)
Posted by Andrea Turli <no...@github.com>.
thanks @nacx
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ec03b710)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1159#issuecomment-346315402
Re: [jclouds/jclouds] [JCLOUDS-1360] add support for block device
mappings to Nova (#1159)
Posted by Andrea Turli <no...@github.com>.
Closed #1159.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1159#event-1353813667