You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/05/01 19:34:11 UTC

[GitHub] nifi pull request #1725: NIFI-3762: Fixing JS errors when referencing servic...

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/1725

    NIFI-3762: Fixing JS errors when referencing services are out of scope

    NIFI-3762:
    - Addressing issue when enabling/disabling controller services when referencing services are not in scope.
    - Fixing enabled/disabled icons for referencing services.
    - Rendering when a reference cycle is detected.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-3762

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1725
    
----
commit a5c84a8689868132a8999529637b57315bd50376
Author: Matt Gilman <ma...@gmail.com>
Date:   2017-05-01T19:32:46Z

    NIFI-3762:
    - Addressing issue when enabling/disabling controller services when referencing services are not in scope.
    - Fixing enabled/disabled icons for referencing services.
    - Rendering when a reference cycle is detected.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1725: NIFI-3762: Fixing JS errors when referencing servic...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1725


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1725: NIFI-3762: Fixing JS errors when referencing services are ...

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1725
  
    @markap14 - I was hoping you might be able to evaluate the PR in the environment where you first encountered the issue.
    @scottyaslan - I was hoping you might be able to review some of the finer details with the client side changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1725: NIFI-3762: Fixing JS errors when referencing services are ...

Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:

    https://github.com/apache/nifi/pull/1725
  
    @mcgilman @markap14 UI code looks good. Thanks @mcgilman this has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1725: NIFI-3762: Fixing JS errors when referencing services are ...

Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/1725
  
    @mcgilman @scottyaslan server-side code looks fine. Rebuilt and deployed to same flow that was having problems before. All looks good! +1 from me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---