You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/05 12:39:29 UTC

[GitHub] [flink] bzhaoopenstack opened a new pull request, #20756: [FLINK-27929][python] Drop support for python36

bzhaoopenstack opened a new pull request, #20756:
URL: https://github.com/apache/flink/pull/20756

   This PR will drop the py36 support for pyflink.
   
   
   ## What is the purpose of the change
   
   py36 had reached its EOL. https://endoflife.date/python
   So need to drop it from pyflink.
   
   
   ## Brief change log
   
     - drop system py36 version validation, increase to 3.7
     - associate py36 doc change
   
   ## Verifying this change
   py36 won't be supported by pyflink 1.17
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] HuangXingBo commented on a diff in pull request #20756: [FLINK-27929][python] Drop support for python36

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on code in PR #20756:
URL: https://github.com/apache/flink/pull/20756#discussion_r991762362


##########
flink-python/setup.py:
##########
@@ -316,16 +316,10 @@ def extracted_output_files(base_dir, file_path, output_directory):
                         'python_full_version >= "3.7" and platform_system != "Windows"',
                         'httplib2>=0.19.0,<=0.20.4', apache_flink_libraries_dependency]
 
-    if sys.version_info < (3, 7):
-        # python 3.6 upper and lower limit
-        install_requires.append('numpy>=1.14.3,<1.20')
-        install_requires.append('pandas>=1.0,<1.2.0')
-        install_requires.append('pyarrow>=0.15.1,<7.0.0')
-    else:
-        # python 3.7, 3.8 and 3.9 upper limit and M1 chip lower limit,
-        install_requires.append('numpy>=1.21.4,<1.22.0')
-        install_requires.append('pandas>=1.3.0,<1.4.0')
-        install_requires.append('pyarrow>=5.0.0,<9.0.0')
+    # python 3.7, 3.8 and 3.9 upper limit and M1 chip lower limit,

Review Comment:
   since we drop the support python3.6, we can put these install dependencies in `install_requires` directly.



##########
flink-python/setup.py:
##########
@@ -27,12 +27,12 @@
 
 from setuptools import setup, Extension
 
-if sys.version_info < (3, 6):
-    print("Python versions prior to 3.6 are not supported for PyFlink.",
+if sys.version_info < (3, 7):
+    print("Python versions prior to 3.7 are not supported for PyFlink.",
           file=sys.stderr)
     sys.exit(-1)
-elif sys.version_info.minor == 6:
-    warnings.warn("Python version 3.6 won't be supported for PyFlink after 1.16.")

Review Comment:
   we haven't planned to drop support python3.7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #20756: [FLINK-27929][python] Drop support for python36

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20756:
URL: https://github.com/apache/flink/pull/20756#issuecomment-1236967167

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ae345fe71057b9e57257df61de907f05f224355b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ae345fe71057b9e57257df61de907f05f224355b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ae345fe71057b9e57257df61de907f05f224355b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] dianfu closed pull request #20756: [FLINK-27929][python] Drop support for python36

Posted by "dianfu (via GitHub)" <gi...@apache.org>.
dianfu closed pull request #20756: [FLINK-27929][python] Drop support for python36
URL: https://github.com/apache/flink/pull/20756


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] dianfu commented on pull request #20756: [FLINK-27929][python] Drop support for python36

Posted by "dianfu (via GitHub)" <gi...@apache.org>.
dianfu commented on PR #20756:
URL: https://github.com/apache/flink/pull/20756#issuecomment-1445749286

   Closed this PR as this should have already been supported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org