You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/07/12 21:46:22 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6939: Add additional test coverage for aggregaes using dates/times/timestamps/decimals

tustvold commented on code in PR #6939:
URL: https://github.com/apache/arrow-datafusion/pull/6939#discussion_r1261755441


##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1710,13 +1854,25 @@ select sum(c1), arrow_typeof(sum(c1)) from d_table;
 ----
 100 Decimal128(20, 3)
 
+query TRT
+select c2, sum(c1), arrow_typeof(sum(c1)) from d_table GROUP BY c2 ORDER BY c2;
+----
+A 1100.045 Decimal128(20, 3)

Review Comment:
   I'm not 100% sure whether the output type is correct, but I also don't know that it isn't so :+1:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org