You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/03/15 09:15:41 UTC
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
pranav.lodha@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18323
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
IMPALA-11145: Block reads on JSON table until we support it
Since, scanning JSON tables leads to a BE crash, it's been blocked at
FE using appropriate error message. An end-to-end test has also been
included to test the blocking and the error message.
Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/metadata/test_hms_integration.py
2 files changed, 37 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/18323/1
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10292/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 11:27:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@475
PS4, Line 475: S
nit: need a space
http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@475
PS4, Line 475: ,this
nit: need a space before "this"
http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@484
PS4, Line 484: }
Please move this block before the calculation of "firstComplexTypedCol", i.e. move it to line 467.
http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py@132
PS4, Line 132: def test_json_file_unsupported(self, unique_database):
This test needs to insert data via Hive, which requires a running HiveServer2. We need to skip it when running on non-HDFS builds since there are no HiveServer2 or YARN running. Import and add these skip annotations before the method:
https://github.com/apache/impala/blob/80307d39976c27a7ada11e7cd776a30b09a3abdc/tests/metadata/test_hms_integration.py#L132-L138
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 23:40:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
IMPALA-11145: Block reads on JSON table until we support it
Since, scanning JSON tables leads to a BE crash, it's been blocked at
FE using appropriate error message. An end-to-end test has also been
included to test the blocking and the error message.
Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/metadata/test_hms_integration.py
2 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/18323/4
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
IMPALA-11145: Block reads on JSON table until we support it
Since, scanning JSON tables leads to a BE crash, it's been blocked at
FE using appropriate error message. An end-to-end test has also been
included to test the blocking and the error message.
Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/metadata/test_hms_integration.py
2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/18323/6
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 12:58:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10308/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 15:02:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
IMPALA-11145: Block reads on JSON table until we support it
Since, scanning JSON tables leads to a BE crash, it's been blocked at
FE using appropriate error message. An end-to-end test has also been
included to test the blocking and the error message.
Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Reviewed-on: http://gerrit.cloudera.org:8080/18323
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/metadata/test_hms_integration.py
2 files changed, 33 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18323/2/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18323/2/tests/metadata/test_hms_integration.py@151
PS2, Line 151: .
flake8: E126 continuation line over-indented for hanging indent
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 11:07:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 4:
(2 comments)
> Patch Set 2:
>
> (1 comment)
Done
http://gerrit.cloudera.org:8080/#/c/18323/1/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18323/1/tests/metadata/test_hms_integration.py@132
PS1, Line 132: ,
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/18323/1/tests/metadata/test_hms_integration.py@151
PS1, Line 151: (
> flake8: E126 continuation line over-indented for hanging indent
Done
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 14:43:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
IMPALA-11145: Block reads on JSON table until we support it
Since, scanning JSON tables leads to a BE crash, it's been blocked at
FE using appropriate error message. An end-to-end test has also been
included to test the blocking and the error message.
Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/metadata/test_hms_integration.py
2 files changed, 37 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/18323/2
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 12:58:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10321/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 07:34:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18323/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18323/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@a485
PS5, Line 485:
nit: add back this blank line
http://gerrit.cloudera.org:8080/#/c/18323/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@485
PS5, Line 485:
nit: remove this blank line
http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py@132
PS4, Line 132: def test_json_file_unsupported(self, unique_database):
> This test needs to insert data via Hive, which requires a running HiveServe
Please ignore this since the class level already has such annotations.
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 06:43:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7958/
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 17:21:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 05:16:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7963/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 00:49:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 00:48:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7958/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 12:58:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18323/1/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18323/1/tests/metadata/test_hms_integration.py@132
PS1, Line 132: ,
flake8: E231 missing whitespace after ','
http://gerrit.cloudera.org:8080/#/c/18323/1/tests/metadata/test_hms_integration.py@151
PS1, Line 151: .
flake8: E126 continuation line over-indented for hanging indent
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 09:16:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10291/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 09:35:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18323/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18323/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@381
PS2, Line 381: private boolean hasJSON(Set<HdfsFileFormat> fileFormat){
We just use this once. Probably not worth a method for it.
http://gerrit.cloudera.org:8080/#/c/18323/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@416
PS2, Line 416: checkForSupportedFileFormats();
Could you move the check into this method?
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 11:10:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
IMPALA-11145: Block reads on JSON table until we support it
Since, scanning JSON tables leads to a BE crash, it's been blocked at
FE using appropriate error message. An end-to-end test has also been
included to test the blocking and the error message.
Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/metadata/test_hms_integration.py
2 files changed, 34 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/18323/5
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10319/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 03:43:36 +0000
Gerrit-HasComments: No