You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/16 02:22:14 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request, #18383: Remove `SubjectSupplier` & `OperationSupplier`
lanchengx opened a new pull request, #18383:
URL: https://github.com/apache/shardingsphere/pull/18383
Changes proposed in this pull request:
- Remove `SubjectSupplier`
- Remove `OperationSupplier`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #18383: Remove `SubjectSupplier` & `OperationSupplier`
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #18383:
URL: https://github.com/apache/shardingsphere/pull/18383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18383: Remove `SubjectSupplier` & `OperationSupplier`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18383:
URL: https://github.com/apache/shardingsphere/pull/18383#issuecomment-1157177974
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18383?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18383](https://codecov.io/gh/apache/shardingsphere/pull/18383?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9698162) into [master](https://codecov.io/gh/apache/shardingsphere/commit/98d93375c8635f6179ab493b739c8aa35e0b61e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98d9337) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #18383 +/- ##
============================================
+ Coverage 59.14% 59.21% +0.06%
+ Complexity 2199 2197 -2
============================================
Files 3733 3722 -11
Lines 54734 54759 +25
Branches 9302 9302
============================================
+ Hits 32374 32427 +53
+ Misses 19609 19580 -29
- Partials 2751 2752 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../rdl/drop/DropDefaultSingleTableRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JkbC9kcm9wL0Ryb3BEZWZhdWx0U2luZ2xlVGFibGVSdWxlU3RhdGVtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...ser/statement/rql/show/ShowResourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSZXNvdXJjZXNTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ement/rql/show/ShowRulesUsedResourceStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSdWxlc1VzZWRSZXNvdXJjZVN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...atement/rql/show/ShowUnusedResourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dVbnVzZWRSZXNvdXJjZXNTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ement/DropDatabaseDiscoveryHeartbeatStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L0Ryb3BEYXRhYmFzZURpc2NvdmVyeUhlYXJ0YmVhdFN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [.../statement/DropDatabaseDiscoveryRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L0Ryb3BEYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../statement/DropDatabaseDiscoveryTypeStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L0Ryb3BEYXRhYmFzZURpc2NvdmVyeVR5cGVTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...sql/parser/statement/DropEncryptRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9zdGF0ZW1lbnQvRHJvcEVuY3J5cHRSdWxlU3RhdGVtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...statement/DropReadwriteSplittingRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9Ecm9wUmVhZHdyaXRlU3BsaXR0aW5nUnVsZVN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [.../ShowReadwriteSplittingReadResourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9TaG93UmVhZHdyaXRlU3BsaXR0aW5nUmVhZFJlc291cmNlc1N0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [90 more](https://codecov.io/gh/apache/shardingsphere/pull/18383/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18383?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18383?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [98d9337...9698162](https://codecov.io/gh/apache/shardingsphere/pull/18383?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org