You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/25 23:21:42 UTC

[GitHub] [arrow] shollyman edited a comment on pull request #10603: ARROW-13191: [Go] allow external schema in ipc readers

shollyman edited a comment on pull request #10603:
URL: https://github.com/apache/arrow/pull/10603#issuecomment-868867445


   The issue seems to be the change of expectations.  The internal/arrdata writes schema messages, but validation also passes in an external schema (which is being used for extra validation).  Consuming the first Message from the MessageReader in the short-circuit change unbreaks the tests, but is clearly the wrong behavior.
   
   What's the right thing to do here?  Change arrdata to write a with schema and without schema, and test using both embedded and external schema?  Should NewReader somehow peek into the stream and disregard an initial schema message if an external schema was passed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org