You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "e-geist (via GitHub)" <gi...@apache.org> on 2023/02/06 16:47:37 UTC
[GitHub] [superset] e-geist opened a new issue, #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
e-geist opened a new issue, #23001:
URL: https://github.com/apache/superset/issues/23001
If we reload a page (we created) with an embedded dashboard, that was successfully loaded before, "Access is Denied" popups appear in the upper right corner of the embedded dashboard. These disappear after some seconds and the dashboard is properly shown.
We noticed this happens, because the browser sends initially an "old cookie" from previous requests - Superset apparently tries using it and shows "Access is Denied".
These popups confuse users as the dashboard works fine, but there are some warnings shown.
There is also nothing the access is denied to, it's more of a cosmetic problem.
#### How to reproduce the bug
1. Enable embedding dashboards in superset via config
2. Enable a dashboard to be embedded
3. Implement a guest token fetching mechanism
4. Make sure cookie policies are set correctly
5. Load page with embedded dashboard (-> no "Access is Denied" popups as this is the first access)
6. Reload page with embedded dashboard ("Access is Denied" popups appear and disappear)
### Expected results
Upon reloading of a page with an embedded dashboard, the dashboard is properly shown without warnings if there are no problems with authentication/role access.
### Actual results
Upon reloading of a page with an embedded dashboard, "Access is Denied" warnings pop up before the actual dashboard is shown.
We would expect that even if the browser sends an old cookie, it is just discarded, as the provided guest token will be used anyways.
### Environment
browser type and version: Firefox
superset version: 2.0.1
python version: Python 3.8.12
any feature flags active: nothing too special - we use embedding dashboards, but this also occurs for normal dashboards
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
By manually deleting the session cookie of the superset instance, before reloading the page with the embedded dashboard, the warnings can be prevented. This is of course not feasible for end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] e-geist commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "e-geist (via GitHub)" <gi...@apache.org>.
e-geist commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1482449662
Hi @eschutho ,
sorry for the late response, will test as soon as possible and report.
Currently unfortunately very busy with other stuff - but will try to get back to it next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie) [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1747805792
Great. I'll close this ticket then. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1467138567
@lilykuang tried reproducing it and hasn't been able to yet. I think we're going to have to push this fix out to 2.1.1. Hopefully we can get someone to put up a fix for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] e-geist commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "e-geist (via GitHub)" <gi...@apache.org>.
e-geist commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1467666488
I added some notes to the additional context section above.
@lilykuang @eschutho
Also feel free to contact me directly via Slack or here for further debugging/information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] e-geist commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "e-geist (via GitHub)" <gi...@apache.org>.
e-geist commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1491921837
So we were finally able to verify the fix. With 2.1rc3 we don't see any Access Denied messages popping up anymore!
The bug is fixed
Thank you @lilykuang @eschutho ! Really appreciate the it!
(Not sure what the policy about closing issues is? Do I close it or does it get closed?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1472448409
Thanks @e-geist It looks like this may have been fixed in this PR. https://github.com/apache/superset/pull/21157/files. If you would like to test it out on the latest 2.1rc2 release, can you let us know if it fixes the issue for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lucasfernando commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "lucasfernando (via GitHub)" <gi...@apache.org>.
lucasfernando commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1701119624
I just added "can log on Superset" permission to Public role and that solved the problem for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie) [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho closed issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
URL: https://github.com/apache/superset/issues/23001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cwegener commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1701949522
> I just added "can log on Superset" permission to Public role and that solved the problem for me.
Yeah. Ever since I've included that permissions a couple of months ago, I haven't seen the "Access denied" toast for embedded dashboards. I think that is the one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] vivek-kandhvar commented on issue #23001: Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie)
Posted by "vivek-kandhvar (via GitHub)" <gi...@apache.org>.
vivek-kandhvar commented on issue #23001:
URL: https://github.com/apache/superset/issues/23001#issuecomment-1421895345
Yeah, this is very annoying and we were also clueless. Thanks for raising the bug. Hopefully we will have a fix soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org