You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/01/21 13:41:45 UTC

[Bug 124066] New: get rid of an extraneous parentheses in "if((A==B))"

https://issues.apache.org/ooo/show_bug.cgi?id=124066

            Bug ID: 124066
        Issue Type: DEFECT
           Summary: get rid of an extraneous parentheses in "if((A==B))"
           Product: General
           Version: 4.1.0-dev
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P4
         Component: code
          Assignee: issues@openoffice.apache.org
          Reporter: hdu@apache.org
                CC: issues@openoffice.apache.org

When there is an assignment within an "if" condition then there is a dubious
convention to add an extra pair of parentheses to silence an eventual compiler
warning about a suspicious assignment vs. equality ambiguity.

If there is an equality check then that extra pair of parentheses is much more
dubious and Clang is right to warn about it. The extra parentheses should be
removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124066] get rid of an extraneous parentheses in "if((A==B))"

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124066

--- Comment #1 from SVN Robot <sv...@dev.null.org> ---
"hdu" committed SVN revision 1560012 into trunk:
#i124066# get rid of an extraneous parentheses in "if((A==B))"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Issue 124066] get rid of an extraneous parentheses in "if((A==B))"

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124066

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from hdu@apache.org <hd...@apache.org> ---
Closing the resolved issue.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

[Bug 124066] get rid of an extraneous parentheses in "if((A==B))"

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124066

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
           Assignee|issues@openoffice.apache.or |hdu@apache.org
                   |g                           |
   Target Milestone|---                         |4.1.0

--- Comment #2 from hdu@apache.org <hd...@apache.org> ---
Fixed with the commit above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.