You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/06 03:40:55 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5188: bugfix: fix `TableScan` may contain fields not included in `schema`
jackwener opened a new pull request, #5188:
URL: https://github.com/apache/arrow-datafusion/pull/5188
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4793.
# Rationale for this change
# What changes are included in this PR?
When tablescan projection don't contain field in scan-projection, we should push them into scan-projection
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5188: bugfix: fix `TableScan` may contain fields not included in `schema`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5188:
URL: https://github.com/apache/arrow-datafusion/pull/5188#issuecomment-1420905384
Benchmark runs are scheduled for baseline = 61459d9324fe2b6ae747af3847a577b93cb6dbbf and contender = e222bd627b6e7974133364fed4600d74b4da6811. e222bd627b6e7974133364fed4600d74b4da6811 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6849e9f2d43749cb8f1ba21a481d1a45...02ee34d77e484115bd68e933cb5b6509/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bb9c70b46da8442d9b1ba373bdc7c1e9...72f18d722fd2439a8c63ad9ec1c70fad/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9ed73630c7f64a219346dcfdd17110ec...5b22f107f4854519a1d2183645a3772c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/33513149696947bfb545cf760a867076...053aa464923240fa8a6fdca86550aa41/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5188: bugfix: fix `TableScan` may contain fields not included in `schema`
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5188:
URL: https://github.com/apache/arrow-datafusion/pull/5188#issuecomment-1418464186
cc @HaoYang670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on pull request #5188: bugfix: fix `TableScan` may contain fields not included in `schema`
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #5188:
URL: https://github.com/apache/arrow-datafusion/pull/5188#issuecomment-1418879244
Thank you @jackwener. I'll review this tomorrow. (working overtime today 😂)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #5188: bugfix: fix `TableScan` may contain fields not included in `schema`
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #5188:
URL: https://github.com/apache/arrow-datafusion/pull/5188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on a diff in pull request #5188: bugfix: fix `TableScan` may contain fields not included in `schema`
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #5188:
URL: https://github.com/apache/arrow-datafusion/pull/5188#discussion_r1098186569
##########
datafusion/optimizer/src/push_down_projection.rs:
##########
@@ -291,6 +291,10 @@ fn optimize_plan(
// scans:
// * remove un-used columns from the scan projection
LogicalPlan::TableScan(scan) => {
+ // filter expr mayn't exist in expr in projection.
Review Comment:
```suggestion
// filter expr may not exist in expr in projection.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org