You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/01 08:50:07 UTC

[GitHub] [incubator-doris] hello-stephen opened a new pull request, #9912: add table name in query profile, OlapScanner: -> OlapScanner(lineitem):

hello-stephen opened a new pull request, #9912:
URL: https://github.com/apache/incubator-doris/pull/9912

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   in order to know which table are scanned, add table name in query profile, just OlapScanner: -> OlapScanner(lineitem):
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yiguolei commented on pull request #9912: add table name in query profile, OlapScanner: -> OlapScanner(lineitem):

Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #9912:
URL: https://github.com/apache/incubator-doris/pull/9912#issuecomment-1158351786

   already done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9912: add table name in query profile, OlapScanner: -> OlapScanner(lineitem):

Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9912:
URL: https://github.com/apache/incubator-doris/pull/9912#discussion_r886564503


##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -775,6 +775,7 @@ protected void toThrift(TPlanNode msg) {
             msg.olap_scan_node.setSortColumn(sortColumn);
         }
         msg.olap_scan_node.setKeyType(olapTable.getKeysType().toThrift());
+        msg.olap_scan_node.setTableName(olapTable.getName());

Review Comment:
   tablet name and rollupname 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yiguolei closed pull request #9912: add table name in query profile, OlapScanner: -> OlapScanner(lineitem):

Posted by GitBox <gi...@apache.org>.
yiguolei closed pull request #9912: add table name in query profile, OlapScanner: -> OlapScanner(lineitem):
URL: https://github.com/apache/incubator-doris/pull/9912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org