You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/20 23:15:53 UTC

[GitHub] [incubator-pinot] chenboat opened a new pull request #5905: Add 0.5 license and notice.

chenboat opened a new pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905


   ## Description
   Add a description of your PR here.
   A good description should include pointers to an issue or design document, etc.
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
   * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR otherwise need attention when creating release notes? Things to consider:
   - New configuration options
   - Deprecation of configurations
   - Signature changes to public methods/interfaces
   - New plugins added or old plugins removed
   * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
   ## Release Notes
   If you have tagged this as either backward-incompat or release-notes,
   you MUST add text here that you would like to see appear in release notes of the
   next release.
   
   If you have a series of commits adding or enabling a feature, then
   add this section only in final commit that marks the feature completed.
   Refer to earlier release notes to see examples of text
   
   ## Documentation
   If you have introduced a new feature or configuration, please add it to the documentation as well.
   See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
chenboat commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r475931253



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       I ran the command as specified in the release process:https://cwiki.apache.org/confluence/display/PINOT/Creating+an+Apache+Release#CreatinganApacheRelease-UpdatingLICENSE-binaryfile
   
   The result does not include the plugins. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r475992991



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       hmm, i see. 
   @mcvsubbu @snleee do you know if we should include the plugins dependencies here as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r476003754



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       I think pinot-distribution module just copied the jars from pinot-plugins.
   @chenboat can you try to explicitly add pinot-plugins module into pinot-distributions's pom as a dependency then run the command to see if plugins dependencies are added




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#issuecomment-680698790


   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5905?src=pr&el=h1) Report
   > Merging [#5905](https://codecov.io/gh/apache/incubator-pinot/pull/5905?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc) will **increase** coverage by `0.61%`.
   > The diff coverage is `71.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5905/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5905?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5905      +/-   ##
   ==========================================
   + Coverage   66.44%   67.06%   +0.61%     
   ==========================================
     Files        1075     1184     +109     
     Lines       54773    62044    +7271     
     Branches     8168     9479    +1311     
   ==========================================
   + Hits        36396    41611    +5215     
   - Misses      15700    17353    +1653     
   - Partials     2677     3080     +403     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integration | `43.65% <50.67%> (?)` | |
   | #unittests | `58.67% <58.38%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5905?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `52.83% <0.00%> (-13.84%)` | :arrow_down: |
   | [...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=) | `53.33% <0.00%> (-3.81%)` | :arrow_down: |
   | [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `44.44% <0.00%> (-4.40%)` | :arrow_down: |
   | [.../org/apache/pinot/client/ResultTableResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L1Jlc3VsdFRhYmxlUmVzdWx0U2V0LmphdmE=) | `24.00% <0.00%> (-10.29%)` | :arrow_down: |
   | [...g/apache/pinot/common/metrics/AbstractMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3MuamF2YQ==) | `82.57% <ø> (+7.90%)` | :arrow_up: |
   | [...a/org/apache/pinot/common/metrics/BrokerGauge.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJHYXVnZS5qYXZh) | `91.66% <ø> (+1.66%)` | :arrow_up: |
   | [...g/apache/pinot/common/metrics/ControllerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...mxReporterMetricsRegistryRegistrationListener.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9KbXhSZXBvcnRlck1ldHJpY3NSZWdpc3RyeVJlZ2lzdHJhdGlvbkxpc3RlbmVyLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...org/apache/pinot/common/metrics/MetricsHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NZXRyaWNzSGVscGVyLmphdmE=) | `50.60% <ø> (+1.85%)` | :arrow_up: |
   | ... and [852 more](https://codecov.io/gh/apache/incubator-pinot/pull/5905/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5905?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5905?src=pr&el=footer). Last update [c223dfc...5a8a743](https://codecov.io/gh/apache/incubator-pinot/pull/5905?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
chenboat commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r476210483



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       Thanks @fx19880617. Adding the pinot plugins modules into pinot-distribution's pom (and also the top level pom) can work. But it looks like to me that the pinot-distribution's pom only takes a small set of core modules to avoid bringing too many external dependencies. This outdated doc explains the organization: 
   https://github.com/apache/incubator-pinot/blob/master/docs/code_modules.rst
   
   I wonder if we just want to add all the plugin modules to pinot distribution's pom to derive the set of licenses.
   
   Add @kishoreg here as well how what module we should add to Pinot distributions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
chenboat commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r476210483



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       Thanks @fx19880617. Adding the pinot plugins modules into pinot-distribution's pom (and also the top level pom) can work. But it looks like to me that the pinot-distribution's pom only takes a small set of core modules to avoid bringing too many external dependencies. This outdated doc explains the organization: 
   https://github.com/apache/incubator-pinot/blob/master/docs/code_modules.rst
   
   I wonder if we just want to add all the plugin modules to pinot distribution's pom to derive the set of licenses.
   
   Add @kishoreg here as well how what modules we should add to Pinot distributions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r476000605



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       I would think so, since we are including the plugins along with the product. But I am not sure. Also not sure how to get the plugins into the dependencies or why it does not show up




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
chenboat commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r476969235



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       I added the s3 plugin but there is still no com.amazonaws:aws-java-sdk:1.7.4 dep. Could aws change their dep structure?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] chenboat commented on pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
chenboat commented on pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#issuecomment-680687103


   Thanks for the reviews. 
   (1) org.apache.helix:helix-core:0.9.7 is still in the LICENSE-binary file. 
   (2) cddl 1.0 should _not_ go away. I think the current runbook has ambiguity in it (quote below)
      "**Scroll down to the section on the project's compile dependencies (transitive)**"       
      The javax.servlet-api is the direct compile dependencies and thus it is NOT shown up in the transitive dep list. We should modify the instruction to include direct dependencies.
       gpl will still go away as its jar got deleted completed — I can mentioned it in the commit msg.
   
   > Looks ok overall, but a few questions. If you can add that in the commit message that will be useful.
   > (1) Why did Apache Helix go away from LICENSE-binary?
   > (2) Why did cddl and gpl license go away?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] chenboat merged pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
chenboat merged pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5905: Add 0.5 license and notice.

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#discussion_r474445866



##########
File path: LICENSE-binary
##########
@@ -205,172 +205,69 @@ This project bundles some components that are also licensed under the Apache
 License Version 2.0:
 
 com.101tec:zkclient:0.7
-com.amazonaws:aws-java-sdk:1.7.4

Review comment:
       why we removed so many dependencies?
   E.g. this aws-java-sdk is used in pinot-s3 plugin




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org